search

Gruntfuggly / todo-tree

Use ripgrep to find TODO tags and display the results in a tree view
Other
1.4k stars 134 forks source link

Applying include globs to found results leads to zero found items #810

Open AndisGrossteins opened 6 months ago

AndisGrossteins commented 6 months ago

This is not a new issue. It seems that @Gruntfuggly missed the debug log lines reported in #641

I think it's more likely that the view has gone missing.

@Gruntfuggly in https://github.com/Gruntfuggly/todo-tree/issues/641#issuecomment-1306226185

That issue had nothing to do with missing view.

I've enable debugging and there are clearly results found by ripgrep but after the listing of found results there's this:

20:40:16.480 Found 26 items
20:40:16.480 Applying globs to 26 items...
20:40:16.486 Remaining items: 0

I've tried various include and exclude globs in workspace and user settings but still nothing. The only way to get results is to set the todo-tree.filtering.includeGlobs to an empty array which is suboptimal on larger workspaces.

However, having only the todo-tree.filtering.excludeGlobs defined .

I think something is a bit ducky in the code at src/extension.js:496 but I lack time and mental capacity to investigate further.

Details, just in case:

OS: Win 11 23H2 (10.0.22635.2850) vscode: 1.85.1 ripgrep: 14.0.3 (rev 67ad9917ad)