Gruntfuggly / todo-tree

Use ripgrep to find TODO tags and display the results in a tree view
Other
1.4k stars 134 forks source link

Support border color, width and style in default and custom highlights #838

Open 3noix opened 2 months ago

3noix commented 2 months ago

This PR resolves #582 by adding support of:

I treated the border color similarly to foreground and background colors:

Default values:

Here is the result of a test: test

With these settings in todo-tree.highlights.customHighlight and no foreground and background set in todo-tree.highlights.defaultHighlight: settings1

3noix commented 2 months ago

I had a problem with the VSCode API: I only wanted to add a horizontal line above my comment, without applying a background or a foreground change, and I had a foreground in the todo-tree.highlights.defaultHighlight... and in this case it is impossible to reference the color of comments of the theme:

And this is some weird behavior that 2 different invalid values (as said by the warning) have different results.

settings