search

Gruntfuggly / vscode-journal-view

Adds a sidebar viewlet for vscode-journal
25 stars 9 forks source link

vscode.uri.file is not a constructor - The Journal window fails to load anything #11

Closed brianmccarty closed 5 years ago

brianmccarty commented 5 years ago

Running:

Version: 1.32.0-insider (system setup) Commit: 7d0c9e6fa0bedcf71bdae86c02611b65362795a3 Date: 2019-02-26T06:19:00.351Z Electron: 3.1.3 Chrome: 66.0.3359.181 Node.js: 10.2.0 V8: 6.6.346.32 OS: Windows_NT x64 10.0.17763

vscode-journal-view 0.0.22

2019-02-26_09-18-25

notificationsAlerts.ts:38
Error: vscode.Uri.file is not a constructor
    at JournalDataProvider.getTreeItem (c:\Users\bmccarty\.vscode-insiders\extensions\gruntfuggly.vscode-journal-view-0.0.22\dataProvider.js:148:36)
    at define.fetchChildrenNodes.a.asPromise.then.Promise.all.u.coalesce.map.a.asPromise (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:441:138)
    at t.asPromise.Promise (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:48:58)
    at new Promise (<anonymous>)
    at Object.t.asPromise (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:48:32)
    at define.fetchChildrenNodes.a.asPromise.then.Promise.all.u.coalesce.map.e (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:441:106)
    at Array.map (<anonymous>)
    at define.fetchChildrenNodes.a.asPromise.then.e (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:441:97)
Gruntfuggly commented 5 years ago

This seems to be due to something changing in the API. I need to find out what is being changed as the current implementation is correct according to the documentation, and works as expected with the stable release of vscode.

brianmccarty commented 5 years ago

I'm happy to test

Gruntfuggly commented 5 years ago

Fixed in the latest version.

brianmccarty commented 5 years ago

Indeed 0.0.23 fixed the issue. Thank you for the quick fix.