search

GsActions / commit-message-checker

GitHub Action that checks commit messages of pushes and pull request against a regex pattern
MIT License
99 stars 56 forks source link

Check for github title prefix doesn't work #48

Closed simonschaufi closed 2 years ago

simonschaufi commented 3 years ago

I created a wrong commit in order to test the new github action. Then I ammended to the commit and fixed it, I expected the action to become green but it still failed. Then I fixed the PR title and included the "[BUGFIX]" prefix as well, still failing...

This is my config

Run gsactions/commit-message-checker@v1
  with:
    pattern: \[[^]]+\] .+$
    flags: gm
    error: Your first line has to contain a commit type like "[BUGFIX]".
    excludeTitle: false
    excludeDescription: false
    checkAllCommitMessages: false
    accessToken: false

and this is my output:

Checking commit messages against "\[[^]]+\] .+$"...
- failed: "[BUGFIX] Testing commit message github action"
Error: Error: Your first line has to contain a commit type like "[BUGFIX]".

Both, my github title and my commit message have the "[BUGFIX]" prefix and the action still fails.

See my attempts here to play with it https://github.com/FriendsOfTYPO3/extension_builder/pull/453