search

GsActions / commit-message-checker

GitHub Action that checks commit messages of pushes and pull request against a regex pattern
MIT License
99 stars 56 forks source link

Action doesn't work if one PR contains more commits #51

Closed acearth closed 2 years ago

acearth commented 2 years ago

Thanks to the author, we can use this action to check commit message following the proper format.

But I found the action failed to check following situations: (1) the PR contains 2 or more commits; (2) at least one commit in the PR following the proper format; (3) at least one commit in the PR broken the rule of proper format. In this case, the check still treat the situation as proper one then check pass. but in the controversary, the action check shall be failed due to "at least one commit broken the rule of format".

Can you let me know, how to enable the action to check on every commit of one PR. Or, is it possible to improve in next version?

gilbertsoft commented 2 years ago

@acearth Please check the checkAllCommitMessages option see https://github.com/GsActions/commit-message-checker#configuration

InPermutation commented 2 years ago

The example in README.md refers to

gsactions/commit-message-checker@v1

but that release doesn't contain the checkAllCommitMessages.

JobaDiniz commented 2 years ago

Does the checkAllCommitMessages check only PR commits? Or does it check all the commits in the repository? Because in my case, the team started to adopt standard commit messages, but there are a lot of commits in the history that does not follow the pattern.