search

GsActions / commit-message-checker

GitHub Action that checks commit messages of pushes and pull request against a regex pattern
MIT License
99 stars 56 forks source link

Commit ammedment is not working #76

Closed manavtidhan closed 1 year ago

manavtidhan commented 2 years ago

Code of Conduct

Is there an existing issue for this?

GitHub-hosted runner

ubuntu-latest

Additional runner information

No response

Current Behavior

After github action failed as it didnot find the regex in the commit message . but it still failed when commit message are rewrited and pushed.

Expected Behavior

It should pass if the commit message is updated as per the regex

Steps To Reproduce

I have put regex like below 

      - name: Check Jira ID or Skip tag
        uses: gsactions/commit-message-checker@v1
        with:
          pattern: '(ED-[\d]+|TECH)'
          checkAllCommitMessages: 'true'
          accessToken: ${{ secrets.GITHUB_TOKEN }}
          error: 'You need at least Jira ID or Skip tag i.e [ED-123] | [skip|no issue].'

so to reproduce the problem , you can commit a message without the Jira ID i,e ED-123 , this one will fail which is expected but when you ammend your pushed commit then it should passed.

Anything else?

No response

gilbertsoft commented 2 years ago

Hi @manavtidhan , thanks for your report. Please head to the debugging section at https://github.com/GsActions/commit-message-checker#troubleshooting-and-debugging and check why the action is failing. I currently guess it fails at the PR title and not the commit message.

gilbertsoft commented 1 year ago

Closing because of no feedback.