search

GsDevKit / GsDevKit_home

master GsDevKit project
http://gsdevkit.github.io/GsDevKit_home
MIT License
31 stars 36 forks source link

updated gsdevkit_launcher use of mktemp to support both linux and OSX #305

Open JupiterJones opened 3 years ago

JupiterJones commented 3 years ago

on OSX the -p

option is not supported and the XXX replacement only works if it's at the end of the file name.

command was changed to: mktemp /tmp/gsdevkit.XXXXXXXXXX

dalehenrich commented 3 years ago

@JupiterJones, I don't think the the travis build failure is related to https://travis-ci.org/github/GsDevKit/GsDevKit_home/jobs/762710796, although it may be true that the issue_260 branch never worked with 2,4,8 ... also I don't think it is necessary to spend too much time on issue_260 branch ... the issue_260_2021 branch is a fork off of a recent master branch (issue_260 is a couple of years old) ... and my plan is to basically cherry-pick things from issue_260 that are needed and then modify them to work superdoit ...

With that said, it IS interesting to know that -p option doesn't work in OSX, since I may use similar code in tODE and Rowan(?), so I will want to make a scan to clean them up ... before you hit them again :)

dalehenrich commented 3 years ago

Oh and I made you a member of the Core team so you should have admin privileges and you should be able to merge pull requests yourself ...