search

GsDevKit / zinc

Zinc HTTP Components is an open-source Smalltalk framework to deal with the HTTP networking protocol.
MIT License
4 stars 10 forks source link

Issue #83 (ZnUnknownHttpMethod errors) #95

Closed dassi closed 3 years ago

dassi commented 3 years ago

Issue #83 on GemStone, fix for repeatedly creating a ZnUnknownHttpMethod error on every single request.

dassi commented 3 years ago

Solution taken from here: https://github.com/GsDevKit/GsDevKit_home/issues/169#issuecomment-418545793

dalehenrich commented 3 years ago

@dassi, the fix looks good, but It seems that the github actions weren't triggered for this PR ... so unless this is a problem for you, I plan to fiddle around with the github actions to see if I can trigger a run before doing the merge ...

Much appreciated by the way!

dalehenrich commented 3 years ago

... it looks like I was able to get PR actions to run

dalehenrich commented 3 years ago

... well the action ran but only on gsmaster and not for this PR ... also a bunch of failures on master branch in web socket tests ... I don't have the cycles to fully focus on resollving the gs_master issue, but I'll try to squeeze in some time over the next day or two to get things back in shape ...

dassi commented 3 years ago

@dalehenrich github actions are new to me, some sort to trigger CI tests, I guess. I'm happy to contribute tiny bits, happy if they make it to the main branch sometime. Not in a hurry, since my app now runs on my branch. Thanks! :-)

dalehenrich commented 3 years ago

@dassi good to know ... github ci is like travis-ci, but travis-ci has shut down for open source projects ... the tiny bits are the important bits so your contributions are much appreciated ...