GuGuss / ARTE-7-Downloader

User script to download videos from the ARTE+7 website
GNU General Public License v3.0
263 stars 33 forks source link

Does it still work? #5

Closed aratinau closed 10 years ago

aratinau commented 10 years ago

Hello! I'm an user fan of this extension (by the way thank you so you very much :) but until this morning nothing appears. Even if it's the v1.0 or 1.2. Everything disappear :( I'dont know if it's me or... you know...

Thank you for your helping !

nebelgestalt commented 10 years ago

It's not just you, it stopped working for me, too. Looks like arte has made some changes to the structure of those video pages.

I'm a quite a JavaScript noob, so this might be a bit crude. But on line 51 of arte-downloader.user.js (v1.2), replace "//[@id='details-focus']" with "body", and on line 83, replace "//[@id='details-focus']/div/div/div/div/div[2]" with "//*[@arte_vp_autostart=1]", and you should get working links to the mp4 files appended to the bottom of each video's page.

aratinau commented 10 years ago

And it's work again :) thank you nebelgestalt the "Javascript noob" ;-)

edit: ok now new problem: when I change the version (I want the original) and then I click on the button the version doesn't change... :(

cicithesquirrel commented 10 years ago

I made a pull request to fix this just two days ago :-) Not exactly the same changes as recommended by nebelgestalt, but anyway it seems to work.

@aymerixp: I don't understand what your new problem is... Can you give more explanations ?

spkrn commented 10 years ago

It works now ! thanks nebelgestalt ! I'm a big fan of this extension too. Thanks to the dev

slangenbach commented 10 years ago

I can confirm the fixes of @nebelgestalt work. Thanks a lot!

nebelgestalt commented 10 years ago

I've been playing around with this a bit, and it happened to me a couple of times that this "arte_vp_autostart" flag was not set for some videos, so that the script didn't work because it didn't recognise which "div"-tag to extract the video urls from. I just can't find a better XPath term to use...

aratinau commented 10 years ago

@cicithesquirrel well when I change the version of the video (french version, original version or german version) and then I click the button of the extension, in the new tab, the video is still in french, and I would like to download the original version.

cicithesquirrel commented 10 years ago

@aymerixp Sorry, I can't reproduce the behavior you describe. And I've no idea of what could do that. When I change the language, the page is actually fully changed with a different URL (e.g. going from http://www.arte.tv/guide/de/046571-000/country-roads-der-herzschlag-amerikas to http://www.arte.tv/guide/fr/046571-000/country-music-l-ame-de-l-amerique). The Arte7Downloader script is then re-executed and can only find the videos URLs present in the page, which are only those of the selected language.

aratinau commented 10 years ago

@cicithesquirrel Thank you to help me. I was not talking about the language of the website but about the sound version of the video. Exemple: I would like to download Fleming in english : http://i60.tinypic.com/153xpx0.jpg so i choose VOSTF and then, if I click the "Download High Quality" button the version downloaded is still in french. Can you reproduce the behavior ?

GuGuss commented 10 years ago

Hi ! 1.3 has a proper fix for it.

Arte website changed some HTML ;-)

cicithesquirrel commented 10 years ago

Sorry, 1.3 does not work for me. I get "Uncaught TypeError: Cannot read property 'appendChild' of null" at line 53 when the page is loading. Xpath expression of line 51 should be "/html/body/div[3]/section[2]".

aratinau commented 10 years ago

It does not work for me too !

GuGuss commented 10 years ago

Oups, my mistake, I was targeting the autoloader which is not always there on the URL.

The last commit should fix this.

GuGuss commented 10 years ago

Seems that it's now fixed. Closing this issue.

aratinau commented 10 years ago

Merci m'sieur