GuGuss / ARTE-7-Downloader

User script to download videos from the ARTE+7 website
GNU General Public License v3.0
263 stars 33 forks source link

container div doesn't show up #64

Closed vss-devel closed 6 years ago

vss-devel commented 6 years ago

Issue information

It appears the content of the page is getting rewritten dynamically by the React.js. A workaround is to attach the container div just below the <div id="root">.

apcloic commented 6 years ago

@vss-devel could you plz give some further explanations on how to attach div container below <div id="root"> ?

vss-devel commented 6 years ago

@apcloic here you are:

@@ -605,8 +605,11 @@
                 // Arte Tracks
                 if (stringStartsWith(window.location.href, "http://tracks.arte")) {
                     parent = getParent(videoElement, '', "video");
+                    insertAfter(container, parent);
+                } else {
+                    parent = document.getElementById( 'root' );
+                    parent.parentElement.insertBefore(container, parent);
                 }
-                insertAfter(container, parent);
             }
         }
apcloic commented 6 years ago

@vss-devel ty very much, you rock ! ^^

GuGuss commented 6 years ago

A fix has been pushed in 2.8 version (See #68)

@vss-devel @apcloic Can you upgrade the script and confirm that it solves your issue?

apcloic commented 6 years ago

Hi,

Upgrade done, it works perfectly ! ;p ty

2018-02-06 0:36 GMT+01:00 Augustin Delaporte notifications@github.com:

A fix has been pushed in 2.8 version (See #68 https://github.com/GuGuss/ARTE-7-Downloader/pull/68)

Can you upgrade the script and confirm that it solves your issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GuGuss/ARTE-7-Downloader/issues/64#issuecomment-363258354, or mute the thread https://github.com/notifications/unsubscribe-auth/ACy3gPG8JzLKQDbizTpK-bn61bkyUsotks5tR5BsgaJpZM4ROTl6 .

vss-devel commented 6 years ago

@GuGuss After upgrading to 2.8 the downloader's div appears to be quite stable below the video frame.

One issue though: the downloader's div partly covers the text which is just below the video frame:

screenshot

Bumbadawg commented 6 years ago

Hello @vss-devel, we can close this issue.

vss-devel commented 6 years ago

OK. No problem.