GuGuss / ARTE-7-Downloader

User script to download videos from the ARTE+7 website
GNU General Public License v3.0
263 stars 33 forks source link

No dowloader when age warning appear on video #69

Closed gansheer closed 5 years ago

gansheer commented 6 years ago

Before posting

  1. Is your browser up-to-date ?
  2. Is your script up-to-date (see installation procedure) ?
  3. Have you tried restarting your web browser ?

Issue information

It seems the script already tried and could not find the place where it normally insert the downloader bar and then does not retry after validation. Error is : Uncaught TypeError: Cannot read property 'insertBefore' of null at insertAfter on code :

function insertAfter(newNode, referenceNode) {
    referenceNode.parentNode.insertBefore(newNode, referenceNode.nextSibling);
}

The bug is not always there : it does not happen when I open the URL from a link (like the current page), but it does when I access the URL by another page of the website or when I open a new tab and paste the url.

gorillamoe commented 6 years ago

Once my pull request got merged, it should start to work again. You can use this drop-in replacement script until then - if you like ;)

gansheer commented 6 years ago

Hello, thank you very much for the script. It works well enough for the moment, except that sometimes it does not show the download links on a page. I am sorry to say I could not find a specific scenario to this behavior, it is quite erratic.

Bumbadawg commented 5 years ago

Hello @gansheer, it seems like it's fixed. Unless it's still the case, can you close this issue ? Thanks!