v3.3: Stream URL not linked in markup (anymore?) + suggestions

[uahim]

thanks a lot for version 3.3.! however, I noticed that the m3u8 url is (no longer?) linked within the markup. the script only creates a button for the mp4 download even if streams are available and even mentioned in the log, e.g. https://www.arte.tv/de/videos/089568-000-A/peace-x-peace-festival-2019/

====== player #01 ======
> 10 formats: 8 MP4 videos | **2 streams**.
peace-x-peace-festival-2019:132:9
> Languages:
    - Deutsch
    - Deutsch - UT französisch
peace-x-peace-festival-2019:138:9
> SQ MP4 in VOA: (...)

any chance to fix that?

also - and this is just a suggestion I didn't want to write in an extra issue - the download buttons currently overlay some interesting info, e.g. program length, next airing, availability time frame and alternative versions for the hearing impaired (via icons).

60 Min.
Verfügbar vom 07/09/2019 bis 07/10/2019
Nächste Ausstrahlung am Montag, 9. September um 01:05

maybe the download bar could be moved to the top of the program-summary div or so

also, the video name span could be hidden if there's only one video (which is usually the case, I think)

[Bumbadawg]

Hi @uahim ! About the streams it gets skimmed if MP4 videos are available

// Remove Apple HLS if HTTP available
        if (nbHTTP[videoElementIndex] > 0) {
            delete qualities[videoElementIndex].XS;
            delete qualities[videoElementIndex].XQ;
        }

For the decoration at the top, i used to set it there to one-fits-all, because at the time there were like 6 players on Arte website. Now it seems they use only 3: a regular player, a playlist player, and the 360 player. If you know/want to tweak it: it's at the beginning of the decoratePlayer function.

Both are doable but i can't atm.

[uahim]

@Bumbadawg thanks a ton for the code explanation!

[gorillamoe]

What do you mean by tweak? Should the "skimming"/"skipping" be removed? That's an easy thing to do. If @GuGuss thinks it's worth it, I would just create a MR and you're good to go :)

Or what else is it that you mean by tweaking, @Bumbadawg? Maybe you were just talking about removing the obsolete code parts, aye?

[Bumbadawg]

Hi @walialu, thanks for joining.

This skimming feature was a convenient way of getting the source video over the livestream, because Arte went from RTMP streams (which are easily retrievable in VLC) to HLS streams which are harder to retrieve (don't know how VLC supports HLS nowadays).

If some users see that getting the HLS livestream is interesting, then yes: this section shall be removed, not for being obsolete but for preventing some user possibilities.

As for your PR proposition, i note that the livestream/playlist code is a bit obsolete since it doesn't decorate the player anymore.. As a design note: the playlist code created a "cbVideoSelector" from the videos in the playlist, and set as "selected" the current playing video/stream. So in this list you could have the video sources + the livestream link. Or set an additional button especially for the stream link, your choice. If you can achieve that or a portion of it, i'll gladly merge your request =)