Update dependency management to use latest release of Google-Mobile-Ads-SDK

GuJEMSAdTech / gujemsiossdk

G+J e|MS iOS Advertising SDK, based on Google Ads SDK

6 stars 5 forks source link

Update dependency management to use latest release of Google-Mobile-Ads-SDK #13

Open mkalmes opened 5 years ago

mkalmes commented 5 years ago

Google-Mobile-Ads-SDK was pinned to v7.24.1. Google updates its SDK consistently, which will not be used by the gujemsiossdk.

This PR changes the dependency to allow automatic updates from Google for v7.x, but doesn't update the example project (this should be addressed separately).

daniel-gerold commented 5 years ago

Danke @mkalmes , schauen wir uns an!

marcelkraus commented 5 years ago

Hallo @daniel-gerold, könnt ihr schon abschätzen, ob und wann der PR gemerged wird? Ich bin der Kollege von @mkalmes, der sich aktuell im (wohlverdienten) Urlaub befindet. :)

Allerbesten Dank!

daniel-gerold commented 5 years ago

@marcelkraus ist im aktuellen Sprint, d.h. passiert diese Woche :)

marcelkraus commented 5 years ago

@daniel-gerold: Sehr cool, allerbesten Dank für die Info!

marcelkraus commented 5 years ago

Hi @daniel-gerold, gibt es was neues? ;) Oder merged ihr den PR gar nicht und 3.2.3 beinhaltet die Anpassungen manuell? VG und besten Dank, Marcel

daniel-gerold commented 5 years ago

@marcelkraus ist in 3.2.3. aufgenommen worden, ohne Merge!

mkalmes commented 5 years ago

Hi @daniel-gerold, Was something wrong with my PR? If I can improve my future contribution to your framework, I would like to ask you for your guidelines, what your looking for in a PR, etc. Besides, we waited for a status change on this PR, which would indicate if we could drop our fork. Without any feedback on this PR, we assumed that you didn’t worked on it yet.

So, how can we contribute to your framework and how do you incorporate changes from Pull Requests?

Best, Marc

Am 31.07.2018 um 11:51 schrieb daniel-gerold notifications@github.com:

@marcelkraus ist in 3.2.3. aufgenommen worden, ohne Merge!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

daniel-gerold commented 5 years ago

@mkalmes nothing wrong with your PR, we just had some trouble internally with our new Mac hardware delivered and therefore purely forgot about the PR and made the change manually. Will use the PR functionality for feature requests!

mkalmes commented 5 years ago

That’s good to hear. Thanks for your reply. 👍

Am 31.07.2018 um 16:30 schrieb daniel-gerold notifications@github.com:

@mkalmes nothing wrong with your PR, we just had some trouble internally with our new Mac hardware delivered and therefore purely forgot about the PR and made the change manually. Will use the PR functionality for feature requests!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.