search

Gua-tk / Linux-Auto-Customizer

bash scripts to automatize the installation and uninstallation of a batch of precoded features in a Linux environment.
https://github.com/Gua-tk
GNU General Public License v3.0
20 stars 6 forks source link

End to add features #19

Closed Axlfc closed 1 year ago

Axlfc commented 1 year ago
AleixMT commented 1 year ago

Notice that in the end of 2023 all the unmerged features will be removed from the git tree by deleting the dangling branches on server side (aproximately one year).

Please, enhance code quality, style, commentaries, documentation, readability, understandibility and traceability of the code of these features. Also, simplify and divide content of bigger features, specially stableDiffusion. There must not be any unused code or configuration that its purpose is not clear. Currently, features are very far from being apt to customizer standards and as thus they can not be merged into develop branch.

This is the issue with the most priority wight now, before any other one that you have assigned.

When the previous requirements are ensured on one of the mentioned features, raise a PR and I will review the code and request further changes to ensure customizer standards if needed.

AleixMT commented 1 year ago

Can you do notflix first? I think that is not going to be that difficult to finish... But if the automatic addition of the subtitles does not work just remove that code and leave the functional and working code. Focus on finishing a feature with a basic functionality instead of increasing its complexity and capacities until the point that you no longer know how to proceed to make it work.

I strongly recommend you that you follow the KISS principle.

AleixMT commented 1 year ago

Also, open a single PR for each feature that you want to merge into develop. Start with notflix

AleixMT commented 1 year ago

@Axlfc Add markdown documentation to notflix feature, it is missing

Axlfc commented 1 year ago

@Axlfc Add markdown documentation to notflix feature, it is missing

PR #91 Review required

AleixMT commented 1 year ago

Split this issue into many issues, one for each individual feature.

I am closing it as won't fix.