search

Guad / GTACoop

An online co-op modification for GTA5
GNU General Public License v3.0
81 stars 71 forks source link

Using Fody/Costura to embed multiple dlls into single one #8

Open 2xlbu4u opened 8 years ago

2xlbu4u commented 8 years ago

I have been using this https://github.com/Fody/Costura.git with my mods for some time now and it works really well. Might want to give it a try for bundling client dlls

-MoMadenU

DorCoMaNdO commented 8 years ago

Seems overly complex, this does the job for my projects, it's a single class, requires a single call per embedded assembly.

Guad commented 8 years ago

Do we really need to bundle dlls? Clients wouldn't be able to update other components on their own, such as NativeUI. And there isn't much a difference between drag and dropping one dll or four.

DorCoMaNdO commented 8 years ago

I don't see much need for it, either way, most players would not update NativeUI on their own, and even if they did, they'll probably assume the one packed with the mod is newer.

Also the link I provided only uses the embedded assemblies when they're missing, so if you have an NativeUI in the same folder, it will use that instead.

2xlbu4u commented 8 years ago

I bundle because it removes the risk of having someone unzip only some of the files or overwrite with ones from someone else's mod. So for instance if someone else has NativeUI in their zip and it's bogus, then your mod is toast.

Not a big concern right now though. You are doing great work and I don't want to distract you :-)