Guake / guake-website

Source code for the Guake website
https://guake.github.io/
3 stars 9 forks source link

Fix build breakage caused by #6 rush-merging. #10

Closed ulidtko closed 4 years ago

ulidtko commented 4 years ago

This fixes build, broken via rush-merging #6 which was made with no respect to .editorconfig.

Jade isn't happy about that:

ulidtko@pasocon ~/s/guake-website (fix-line-wrapping)> jade src/jade/public/index.jade

/usr/local/lib/node_modules/jade/lib/runtime.js:240
  throw err;
  ^

Error: src/jade/includes/header.jade:25
    23|                 li.page-scroll
    24|                     a(href='#sources') Source code
  > 25|         li.page-scroll
    26|             a(href='#about') About
    27| 

Invalid indentation, you can use tabs or spaces but not both

Also supersedes #9 by using native Jade syntax (a(href='...') instead of raw html). @justinclift is credited as the original patch author (and me as only the committer).

ulidtko commented 4 years ago

I'll go on and "self-review" this.

Merging by abusing admin powers — this time, hopefully, non-destructively.

justinclift commented 3 years ago

@ulidtko Just to point out, the running website still has the very broken link for this.

Maybe need to update the webserver? :wink:

ulidtko commented 3 years ago

Hey @justinclift yes I know; unfortunately, I cannot do that, by way of how @gsemet has set up the site. Need to ask him to do it.

gsemet commented 3 years ago

yes i need to update it manually... was set up loooong time before we had easy to use deployment :) I try to fix it asap

ulidtko commented 3 years ago

@gsemet can we also mitigate somehow the bus effect and reduce the risk of losing the site for the second time ?

I mean, if you'd share the access (in private of course), further changes/updates to the site could be made without being blocked on you. What'd ya think?