Guake / guake-website

Source code for the Guake website
https://guake.github.io/
3 stars 9 forks source link

Correcting Weblate links for the Guake Terminal website #19

Closed milotype closed 1 week ago

milotype commented 3 months ago

Please correct the file https://github.com/Guake/guake-website/blob/master/src/jade/public/index.jade in the master branch.

Problem: The Weblate links in the "Can I contribute?" section don´t work correctly and the text isn´t complete because of missing end double quotes. Also, when clicking the link "support Weblate" a "Page not found" appears.

Screenshot: Can I contribute

Current source text without end quotes:

                        | If you are not a developer, you can still contribute to Guake by translating
                        | or improving its translations in <a href="https://hosted.weblate.org/projects/guake/guake/>your language</a>.
                        | Guake users are welcome to <a href="https://weblate.org/donate/>support Weblate</a>
                        | in providing this service for free for OpenSource Projects.

Corrected source text with end quotes:

                        | If you are not a developer, you can still contribute to Guake by translating
                        | or improving its translations in <a href="https://hosted.weblate.org/projects/guake/guake/">your language</a>.
                        | Guake users are welcome to <a href="https://weblate.org/donate/">support Weblate</a>
                        | in providing this service for free for OpenSource Projects.

Solution: Add the missing double quotes directly in the file of the master branch. I´m not a programmer, so please check if my solution works.

P.S. Due to my old Mac computer and Firefox, I´m unfortunately not able to make changes on my guake fork, nor to send pull requests :-(

ulidtko commented 1 week ago

Hi @milotype, you're exactly right. I'd pushed a fix that addresses this issue. Thanks for reporting.