Fix bad line wrapping in the middle of a link

justinclift commented 4 years ago

This fixes a link target that was unintentionally line wrapped mid attribute, instead of in between words. :wink:

This follows on from https://github.com/Guake/guake/issues/1703.

Note that I created this PR "blind" (eg without testing). So having someone look over it first would be a really good idea. :grin:

ulidtko commented 4 years ago

Hi! Thanks for the warning; it heckled me to go and actually check if this compiles.

It doesn't.

ulidtko@pasocon ~/s/guake-website (master)> jade src/jade/public/index.jade

/usr/local/lib/node_modules/jade/lib/runtime.js:240
  throw err;
  ^

Error: src/jade/public/index.jade:239
    237|                         | Guake was originally written by Gabriel Falcão in 2007, and has since become
    238|                         | a vibrant open source project with <a href="https://github.com/Guake/guake/g
  > 239|            | raphs/contributors">many contributors</a>.
    240| 
    241|         .page-scroll
    242|             #sources-hook

Invalid indentation, you can use tabs or spaces but not both

It's not your fault though. Tabs were brought in by @Zensavona in #6. He apparently used an editor which ignores .editorconfig. And Gaetan @gsemet, of course, rushed to merge that without waiting on CI (which would've caught the build failure).

With your change @justinclift — it does work; but I like native Jade syntax better, it's more consistent with surrounding code.

I'll make another PR in a minute and fix both issues there. Despite not merging it — thanks for the patch, anyway!

justinclift commented 4 years ago

No worries at all. :smile:

Guake / guake-website

Fix bad line wrapping in the middle of a link #9