New tabs can not be opened via the tab bar.

Guake / guake

Drop-down terminal for GNOME

https://guake.github.io

GNU General Public License v2.0

4.39k stars 575 forks source link

New tabs can not be opened via the tab bar. #1439

Closed SparkyBluefang closed 5 years ago

SparkyBluefang commented 5 years ago

Guake Terminal: 3.4.0 VTE: 0.48.4 VTE runtime: 0.48.4 Gtk: 3.22.30

In previous versions of Guake, new tabs could be opened by double-clicking the empty space on the tab bar, or by clicking the new tab button. With the Gtk.Notebook tab conversion, tabs can only be opened with the keyboard shortcut or through an existing tab's context menu.

gsemet commented 5 years ago

indeed, this is a feature we do not have anymore, I didn't knew this was used by anyone. It makes sense to reset this feature. Pull Request accepted (should not be that hard to do :p )

corvus1 commented 5 years ago

I'm not sure about double-clicking, but the button I did use pretty regularly.

white-gecko commented 5 years ago

I was always using the double-click and was very confused, that it didn't work anymore. I still feels like a bug for me because it disturbed by usual behavior.

quanzhuo commented 5 years ago

@gsemet, @clarete , @aichingm , @piotrdrag I use double-click frequently. And want this feature back deeply. After review the code commit history, find that the following change removed the double-click feature

commit 0bc835c9420064c7a598e3efb9072aaa4e445bc5
Author: Mario Aichinger <aichingm@gmail.com>
Date:   Wed Aug 15 22:29:33 2018 +0200

    disable custom tabs

diff --git a/data/guake.glade b/data/guake.glade
index d2d20a2..e848c85 100644

I tried to revert this commit , but lots of conflict in guake/guake_app.py. I am not familiar with the code. So It's diffcult for me to resolve the conflict. Could you please help make this feature back?

Thank you ! BRs

piotrdrag commented 5 years ago

@quanzhuo Please don’t ping me on issues I have no relation to.

quanzhuo commented 5 years ago

Hi, piotrdrag, I found you are the main developer, so @ you. I am sorry for boring you, Thank you

piotrdrag commented 5 years ago

I am not a developer.

gsemet commented 5 years ago

Hi ! I a m, but no time to dig this issue yet :(

revast commented 5 years ago

+1, I also think this is a good idea to bring this back. Especially for newbies, the button makes sense.

There is no new tab/close tab in the context menu, which I think should be there as well.
Plus, it would be nice to have the new tabs button configurable in Preferences. I always edited the glade file to put it on left side of the tabs (makes more sense to me, less mouse travel...) , so having this configurable (show left, right, and do not show) would be a real win.
I also changed the icon to something more obvious (a black plus sign ) which I can provide if others like it.

Yakoot commented 5 years ago

i was confused after upgrading that i cannot open a new tab) i hope it will be realized again