With "refocus if open" enabled and Guake focused, must toggle twice to hide

hackel commented 5 years ago

This is an issue in both 3.3.0 and 3.4.0. Ubuntu 18.10 on Xorg.

If I enable the "Refocus if open" option, when Guake has focus, pressing the toggle shortcut does nothing the first time, and it must be pressed again in order to hide Guake. If Guake does not have focus, this option works as expected.

freimair commented 5 years ago

I second that. Same here on Arch Linux, Guake 3.4.1 and Gnome Shell on Wayland.

aichingm commented 5 years ago

[edited] Ah ok, nevermind I was mistaken...

freimair commented 5 years ago

here is a trace created by the latest guake checkout:

start guake: make run (activated "Refocus if open")
hit "toggle shortcut" -> guake shows
hit "toggle shortcut" -> guake hides
hit "toggle shortcut" -> guake shows

hit "toggle shortcut":

Show_hide called
DBG: Restoring the focus to the terminal

hit "toggle shortcut" again:
```
Show_hide called
```

================================================================================ Window display gtk.gdk.WindowState = 0 GDK_WINDOW_STATE_STICKY? False GDK_WINDOW_STATE_WITHDRAWN? False GDK_WINDOW_STATE_ABOVE? False GDK_WINDOW_STATE_ICONIFIED? False Hiding the terminal



responsible code seems to be 
https://github.com/Guake/guake/blob/c3ca237bc43cc46ba5f7747e8a5e58a8f657930f/guake/guake_app.py#L513-L520

Guake / guake

With "refocus if open" enabled and Guake focused, must toggle twice to hide #1468