Closed chax closed 5 years ago
Hi @chax, can you help to upload a picture of your Guake? (with search match)
So we have three problems:
right?
thanks
@chax thanks for your picture, I'll take a look to fix this.
So, terminal didn't affect, but:
That is correct assessment.
i tried to replace line 120 b' background-color: #CFCFCF;'
with line b' border: none;'
and for me, it looks much better already
i will provide screenshot so you can see for youself.
Ok. I have no pbl on "Adwaita" theme.
We probably do no want to hardcode any background color and take the one from the theme
Then this should be easy fix, should i expect next release 3.6.1 soon?
Remove hardcode background-color with Adwaita theme:
The Gtk.Frame will get no color when looking at it. Trying to fix this with both light/dark theme
It also looks better without borders, therefore i set border: none
Here what I have on HEAD:
Nice, much better already, but i also like how it looks without background. Can you make than as a checkbox option somewhere in settings to have no background at all? If that would be to complicated, i'm good with this solution also. At least it takes theme colors now, so it's consistent with rest of design.
I tried transparency it displays the background not the terminal. Don't know how to do it better, but @mlouielu PR does the job with the background color. I release 3.6.1 asap
Very good, this was very fast response in solving this issue. Thanks to both @gsemet and @mlouielu in fixing this so quickly. I'm waiting for 3.6.1, so i can do the packaging for Solus.
No problem, thanks for you quickly report on this :)
I think for transparent the search box & un-padding search box should open another feature request issue.
Yep, for now, this is perfect.
Hi, i just tested this new feature and i must say search box doesn't look good with dark theme because overlay background is light-colored and dark themes usually have light-colored fonts, so it's barely visible and it's very hard to read what you type. At first i thought it's not working because i couldn't see the text at all until i really focused my eyes on the search box. Also, background is not transparent as the rest of the terminal, so it looks really ugly and it really stands out from the rest of design. At least make background the right color (the one provided by the current selected GTK theme).
This is probably due to hardcoded value of background color as can be seen here: https://github.com/Guake/guake/blob/0bba1b06e63584193157e5f670f67e7aa5b17a52/guake/boxes.py#L118-L121