search

Guake / guake

Drop-down terminal for GNOME
https://guake.github.io
GNU General Public License v2.0
4.42k stars 574 forks source link

Guake: Can't reset "Toggle Guake visibility" shortcut key #1591

Open behrangsa opened 5 years ago

behrangsa commented 5 years ago

I want to unassign F12 from "Toggle Guake visibility" but pressing backspace doesn't unset it and sets it back to F12. If I set it to another shortcut key (e.g. F2), pressing backspace sets it back to F2.

There doesn't seem to be a way to unset the shortcut key.

See https://youtu.be/p-94CWgXVM4

Might be related to https://github.com/Guake/guake/issues/1448.

mlouielu commented 5 years ago

That is a "feature", so the user would not remove this accel-key. (guake/prefs.py)

This raise out two things:

  1. The code is broken (alhough is ok) , old_accel is missing, and it probably no need this line
  2. Do we need to let user can remove visibility toggle accek-key?

I am -1 on letting user can remove visiblity toggle accel-key, and not re-map on it.

The only two benifit that I can think is:

a) When user want to remap visibility toggle accel-key, it can do less step, currently user will need to 1) map vis toggle to another key, 2) map target to vis toggle key, 3) re-map vis toggle key. b) Some user may only want to use guake -t to open Guake. But why...?

Or another way is, we accept user remove the key, but when it want to leave the dialog without mapping a accel-key on it, we will bump a warning to user.

User with Wayland should only bother on Guake bump a notification said that "it cannot bind show-hide toggle" when startup, but user can solved this by each window manager global hotkey system.

behrangsa commented 5 years ago
  1. If this is intentional, then the UX needs to be improved. Current UX confuses the user: am I doing something wrong? Are the settings corrupted? Is it a bug? 1.1. As an alternative, I suggest modifying the behavior to make backspace reset the shortcut key to the default shortcut key, instead of whatever the user has assigned.
  2. Granted, I think it should be allowed to remove this key binding. Users might want to disable Guake’s native toggling mechanism and experiment with other drop down tools such as https://github.com/noctuid/tdrop

On Mon, 13 May 2019 at 6:25 pm Louie Lu notifications@github.com wrote:

That is a "feature", so the user would not remove this accel-key. ( guake/prefs.py https://github.com/Guake/guake/blob/master/guake/prefs.py#L1447)

This raise out two things:

  1. The code is broken (alhough is ok) , old_accel is missing, and it probably no need this line
  2. Do we need to let user can remove visibility toggle accek-key?

I am -1 on letting user can remove visiblity toggle accel-key, and not re-map on it.

The only two benifit that I can think is:

a) When user want to remap visibility toggle accel-key, it can do less step, currently user will need to 1) map vis toggle to another key, 2) map target to vis toggle key, 3) re-map vis toggle key. b) Some user may only want to use guake -t to open Guake. But why...?

Or another way is, we accept user remove the key, but when it want to leave the dialog without mapping a accel-key on it, we will bump a warning to user.

User with Wayland should only bother on Guake bump a notification said that "it cannot bind show-hide toggle" when startup, but user can solved this by each window manager global hotkey system.

— You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub https://github.com/Guake/guake/issues/1591#issuecomment-491725158, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAEQE5U4EFLJA6AOXRTBXTPVEQXZANCNFSM4HMJ5MTA .

-- Sent from Gmail Mobile

freekvh commented 4 years ago

Wayland does not seem to work with the way Guake handles the toggle shortcut, so people recommend turning it off and using Gnome's own keyboard bindings. This works, but at start-up you do get an error message that Guake's own binding does not work. So I would request that we be able to completely disable it. Best regards.

ghost commented 4 years ago

+1

I think there is quite a lot of us that run GNOME on Wayland. We have applied the workaround and set a custom keyboard shortcut in GNOME Settings (I have mine set as 'F12' for 'guake -t'). Additionally, I set Guake to auto-start in GNOME Tweak Tool. As is the case right now, when I log into GNOME, I instantly get two unneeded notifications: "A problem happened when binding F12 key." and "Guake is now running."

I have tried to disable Guake's notifications in GNOME Settings, but it doesn't appear to work for these notifications. Why is that the case?

Please add an option to disable the "A problem happened when binding ..." notification, or allow the key to be set to empty. I tried doing this in dconf editor but it just resulted in "A problem happened when binding the '' key" notification. No matter what you try, Guake will attempt to bind a key.

Bujiraso commented 4 years ago

I'm trying to understand -- is there something still blocking the implementation of this fix? It seems simple.

Are we worried about users doing something stupid? We should warn (and then trust) them.

I would like to see this fixed, as well.

SeanPedersen commented 3 years ago

Created a pull request that fixes the issue on my machine by simply allowing to reset the show-hide hot key: https://github.com/Guake/guake/pull/1807