Guake / guake

Drop-down terminal for GNOME
https://guake.github.io
GNU General Public License v2.0
4.41k stars 575 forks source link

Guake 3.6.3 on Ubuntu 19.04 Wayland: Horizontal alignment is ignored #1632

Open behrangsa opened 5 years ago

behrangsa commented 5 years ago

Describe the bug

Horizontal alignment is ignored:

Screenshot from 2019-08-18 14-11-45

Expected behavior

When I set horizontal alignment to center or right, and set the width to less than 100%, the Guake window should be aligned accordingly.

Actual behavior

When I set horizontal alignment to center or right, and set the width to less than 100%, the Guake window remains left aligned.

To Reproduce


$ guake --support Guake Version: 3.6.3 Vte Version: 0.56.2 Vte Runtime Version: 0.56.2 -------------------------------------------------- GTK+ Version: 3.24.8 GDK Backend: __gi__.GdkWaylandDisplay -------------------------------------------------- Desktop Session: ubuntu-wayland -------------------------------------------------- Display: wayland-0 RGBA visual: True Composited: True * Monitor: 0 - DEL Dell U4919DW * Geometry: 5120 x 1440 at 0, 0 * Size: 1200 x 340 mm² * Primary: False * Refresh rate: 59.98 Hz * Subpixel layout: unknown
mlouielu commented 5 years ago

Hi @behrangsa,

This is because Wayland didn't provide the absolute coordinate system, so this won't work on Wayland.

However, you can use GDK_BACKEND=x11 guake, using x11 as the backend for guake should let you use it on Wayland.

behrangsa commented 5 years ago

Thanks for the suggestion @mlouielu, but unfortunately it doesn't work for me.

behrangsa commented 5 years ago

Is this something that can't ever be implemented in Guake for Wayland?

mlouielu commented 5 years ago

FWIK, this is not implantable in Wayland, since the absolute coordinate system is not implemented, any operation involved with that is not workable in Wayland.

behrangsa commented 5 years ago

Apparently Wayland supports absolute positions. Also there are some apps/extensions that can handle window positioning under Wayland with no issues (e.g. the gTile extension for Gnome can move windows to left, right, top half, bottom half, and other more complex locations without any issues).

Is Guake using GTK 2 or 3? Looks like GTK 2 is not working properly under Wayland.

mlouielu commented 5 years ago

I think gTile is Gnome-only, some of the window managers will implement their method for positioning (e.g. yakuake in plasma have the positioning extension), I'm not sure if this the case about gTile. Can you also point out which apps can doing this, I would like to take a look for it.

Relative window positioning is what Wayland is doing, and the last time I glimpse the GTK source code, it shows that the absolute positioning methods are deprecated by them. Mailing list relative with this: 1

I don't sure if GTK have changed in recent month. If that is the case, we can figure out how to support this in guake. Otherwise, I don't holding too much expectation on this based on my previous Google-fu result :(

Guake is using GTK3 after 3.x, GTK2 version guake is not maintain.

mlouielu commented 5 years ago

Note: gTile is using mutter to resize the window. mutter is the GNOME Wayland display server.

behrangsa commented 5 years ago

I don't know much about Wayland, but my interpretation of this page is that Wayland supports absolute positioning: https://wayland.freedesktop.org/libinput/doc/latest/absolute-axes.html

Regards, Behrang (sent from my mobile)

On Mon, Aug 26, 2019, 14:01 Louie Lu notifications@github.com wrote:

Note: gTile https://github.com/gTile/gTile/blob/727a04505898af912543d8a6da46a569dd7284b4/extension.js#L1761 is using mutter to resize the window. mutter https://gitlab.gnome.org/GNOME/mutter is the GNOME Wayland display server.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Guake/guake/issues/1632?email_source=notifications&email_token=AAAEQE2DUZUEZPQWWIOUYILQGNIR7A5CNFSM4IMRJOOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5DGGZI#issuecomment-524706661, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAEQE26KBYUUFHPRMCHYMDQGNIR7ANCNFSM4IMRJOOA .

lyndalopez544 commented 4 years ago

@behrangsa

Is this something that can't ever be implemented in Guake for Wayland?

Hope it'll be implemented in Wayland one day.