search

Guake / guake

Drop-down terminal for GNOME
https://guake.github.io
GNU General Public License v2.0
4.38k stars 577 forks source link

Support resizing with mouse #1744

Open ElijahLynn opened 4 years ago

ElijahLynn commented 4 years ago

Would like to be able to resize the non-fullscreen dropdown with my mouse. Currently there are no resize handles that appear when hovering over the border.

This used to be supported way back, I forget which version but maybe something to do with updating to latest GTK.

If this already exists, I don't see it enabled by default or in the options in Guake 3.7.0.

https://feathub.com/Guake/guake/+81

image

ElijahLynn commented 4 years ago

Here I see some code removed for the resizer: https://github.com/Guake/guake/pull/1073/files#diff-5ce9f1d335e4a6673d0454161bdc6fa6L194-L198

ElijahLynn commented 4 years ago

Ahh, here is discussion I participated in Dec 2018 discussing this > https://github.com/Guake/guake/issues/1339 and the issue is still open with a fairly recent milestone.

ElijahLynn commented 4 years ago

This code is still present/commented out: https://github.com/Guake/guake/blob/master/guake/guake_app.py#L239-L242

ElijahLynn commented 4 years ago

@gsemet I know it isn't much but I can pledge $50 USD for this feature.

I have used Guake for many years and really miss this feature, especially ~compared~ combined with the top/bottom toggle.

ElijahLynn commented 4 years ago

Hrm, I am now thinking maybe I can just use the same code as the top/bottom toggle to dynamically adjust the window size with a keyboard shortcut.

ElijahLynn commented 4 years ago

Oh yeah, working! Will post the "how to" ~soon~ eventually! :rocket:

ElijahLynn commented 4 years ago

https://gitlab.com/snippets/1969882

Peek 2020-04-24 11-49

ElijahLynn commented 4 years ago

After using this for an hour or so now, I actually like this solution much better than using a mouse and wouldn't actually use the mouse resize if it was present because keyboard shortcut is so much faster and efficient than mouse resizing. And, this seems like something that is actually in my wheel house to code up and submit a PR for (and the top/bottom toggle too).

As is now, it "works for me" so that isn't a high motivation to make a PR for these two enhancements.

If you want this too, please post that you would like this functionality too, it will give me more motivation to make my first PR to Guake!

bobpaul commented 3 years ago

@ElijahLynn it's unclear to me what functionality you added. Resize via keyboard is in Guake (Preferences -> Keyboard Shortcuts -> Appearance -> Increase Height / Decrease Height. I've used it for a while; was it not there a year ago? I have mine set to Super + Arrow Up/Down

But I would like to see the ability to resize with the mouse return; it's convenient sometimes.

ElijahLynn commented 3 years ago

@ElijahLynn it's unclear to me what functionality you added. Resize via keyboard is in Guake (Preferences -> Keyboard Shortcuts -> Appearance -> Increase Height / Decrease Height. I've used it for a while; was it not there a year ago? I have mine set to Super + Arrow Up/Down

I don't know if there was one before, but glad to hear it exists now, I'll give it a look soon. Thanks!

ElijahLynn commented 3 years ago

I don't know if there was one before, but glad to hear it exists now, I'll give it a look soon. Thanks!

ctrl + up/down on Linux for Guake works out of the box and I can indeed get rid of my customization!! :rocket:

whitty commented 1 month ago

Sorry to dead-post here, but I just found it with google trying to resolve my problem. The resolution above of keyboard shortcuts is fine for adjusting the height, but there doesn't seem to be a matching option to adjust the width

(I don't do full-width terminals - terminals are 80 characters wide - and only need resizing to work around buggy programs or resize for screen-shares)