Guake / guake

Drop-down terminal for GNOME
https://guake.github.io
GNU General Public License v2.0
4.42k stars 574 forks source link

Guake does not display images when w3m-img is installed #1806

Open bonkmaykrQ opened 3 years ago

bonkmaykrQ commented 3 years ago

Be sure to check the existing issues (both open and closed!), and make sure you are running the latest version of Guake.

For how to run the latest Guake in your computer, please refer to Install from source.

Describe the bug

Guake does not display images when w3m-img is installed

Expected behavior

Google Logo appears

Actual behavior

Text only

To Reproduce

Install w3m and w3m-img through your package manager, then run w3m google.com in both Guake and another terminal (Konsole in this case)


Please run $ guake --support, and paste the results here. Don't put backticks (`) around it! The output already contains Markdown formatting. And make sure you run the command OUTSIDE the Guake.

$ guake --support Guake Version: 3.6.3 Vte Version: 0.60.3 Vte Runtime Version: 0.60.3 -------------------------------------------------- GTK+ Version: 3.24.20 GDK Backend: GdkX11.X11Display -------------------------------------------------- Desktop Session: plasma -------------------------------------------------- Display: :0 RGBA visual: True Composited: True * Monitor: 0 - DEL HDMI-0 * Geometry: 1920 x 1080 at 0, 0 * Size: 509 x 286 mm² * Primary: True * Refresh rate: 60.00 Hz * Subpixel layout: unknown
Davidy22 commented 3 years ago

Did some cursory research, figured out that $WINDOWID needs to be set for this to work. Both gnome-terminal and guake had this issue on my machine, and finding window id with xwininfo and running that through a hex-dec converter then setting it to $WINDOWID fixed the issue completely on gnome-terminal, rendered weirdly and in the wrong place with guake though. Can look further into this, although I did notice some other maintainers of other terminals talking about the implementation being a bit hacky, which inclines me to rather hope for w3m to adopt sixel rendering which we should inherit by default with VTE.

sci-42ver commented 2 years ago

I tried rangerby guake , however , I failed . According to this issue comment

does guake support Kitty's image protocol or SIXEL?

Davidy22 commented 2 years ago

By default, Guake should inherit support for sixels as Guake uses VTE, which implements sixel support.

iconoclasthero commented 6 months ago

Umm, where do things stand with this? readthedocs is incomplete and the website is down so...