Guake / guake

Drop-down terminal for GNOME
https://guake.github.io
GNU General Public License v2.0
4.44k stars 576 forks source link

Guake opens two tabs instead of one #2118

Open kkuriata opened 2 years ago

kkuriata commented 2 years ago

Describe the bug

When spawning a new tab from command line with command parameter -e, there are two tabs opened instead of one.

Expected behavior

My command opens one tab with title set to Test title and executing echo 12345 in it.

Actual behavior

I try to spawn a new tab using a command below, but actually two tabs are opened - both in the same directory (~/some-folder), but only the last one executes echo command.

To Reproduce

Using from terminal (tried from guake and konsole separately, same issue):

guake -n ~/some-folder -r "Test title" -e "echo 12345"

<details><summary>$ guake --support</summary>

Guake Version:      3.9.1.dev0

Vte Version:        0.68.0

Vte Runtime Version:    0.68.0

--------------------------------------------------
GTK+ Version:       3.24.34

GDK Backend:        <GdkX11.X11Display

--------------------------------------------------
Desktop Session: plasma

--------------------------------------------------
Display: :0

RGBA visual: True

Composited: True

* Monitor: 0 - IVO eDP-1
    * Geometry:     1920 x 1080 at 0, 0
    * Size:     309 x 174 mm²
    * Primary:      True
    * Refresh rate: 60.009 Hz
    * Subpixel layout:  unknown
Davidy22 commented 2 years ago

Unable to reproduce, but this is probably because I remember fixing an issue that sounds like this one a few weeks ago. I should polish some more issues off and get a release out so the fix gets out into the wild sometime

jleonar commented 1 year ago

I am on 3.9.0 and I have this issue. Essentially I have a script that creates and sets up five tabs.

guake -r "sandbox-dev" -e "cd ~/ap/ckm && source /usr/local/bin/dev.sh" guake -n "local-dev" -r "local-dev" -e "cd ~/ap/local && source /usr/local/bin/localdev.sh" guake -n "local-dev" -r "local-dev" -e "cd ~/ap/local && source /usr/local/bin/localdev.sh" guake -n "f-dev" -r "f-dev" -e "cd ~/ap/fam" guake -n "f-dev" -r "f-dev" -e "cd ~/ap/fam" guake -s 1

I have this run at startup. It results in 10 tabs. 5 of them being named "Terminal" in between all my renamed tabs. This worked correctly on a previous version but I am not sure what version it was.

ivoshm commented 1 year ago

@jleonar
In Guake 3.9.0, the behaviour of the -e command line switch was changed so that it always opens a new tab (see #2057). It should be enough to omit switch -n (with the parameter) in the example above and it will work as expected.