Guake / guake

Drop-down terminal for GNOME
https://guake.github.io
GNU General Public License v2.0
4.37k stars 577 forks source link

Guake is always center aligned vertically instead of top align #2177

Open madhur opened 1 year ago

madhur commented 1 year ago

Be sure to check the existing issues (both open and closed!), and make sure you are running the latest version of Guake.

For how to run the latest Guake in your computer, please refer to Install from source.

Describe the bug

Earlier Guake used to be always top aligned. With the new version, it seems to be center aligned vertically and there seems to be no way to change this behavior.

Expected behavior

Guake should be top align by default.

Actual behavior

Guake is center aligned

image

To Reproduce

Run Guake 3.11.dev0

Make the height slider slightly smaller so as to not let Guake occupy the whole screen

image


Please run $ guake --support, and paste the results here. Don't put backticks (`) around it! The output already contains Markdown formatting. And make sure you run the command OUTSIDE the Guake.

x guake --support [☸ eks-pt (mec)]

(guake:175112): Gtk-WARNING **: 10:41:36.975: Theme parsing error: gtk-dark.css:5890:26: '-shadow' is not a valid color name

(guake:175112): Gtk-WARNING **: 10:41:36.975: Theme parsing error: gtk-dark.css:5893:14: not a number

(guake:175112): Gtk-WARNING **: 10:41:36.975: Theme parsing error: gtk-dark.css:5894:13: not a number

(guake:175112): Gtk-WARNING **: 10:41:36.975: Theme parsing error: gtk-dark.css:5895:11: Expected a length

$ guake --support Guake Version: 3.11.dev0 Vte Version: 0.72.1 Vte Runtime Version: 0.72.1 -------------------------------------------------- GTK+ Version: 3.24.37 GDK Backend:
jvanmelckebeke commented 1 year ago

also experiencing this issue, to slightly mitigate (but not solve):

  • set displacement in pixels to 1
  • don't set the width to 100%

However, doing this causes the guake window to 'crawl' down after toggling guake visibility.

szflo commented 1 year ago

Same problem here :/

Guake Version: 3.11.dev0 Vte Version: 0.72.1 Vte Runtime Version: 0.72.1

GTK+ Version: 3.24.37 GDK Backend: <GdkX11.X11Display

Desktop Session: None

Display: :0 RGBA visual: True Composited: True

  • Monitor: 0 - AUO eDP1
    • Geometry: 1920 x 1080 at 0, 0
    • Size: 310 x 170 mm²
    • Primary: True
    • Refresh rate: 60.049 Hz
    • Subpixel layout: unknown
madhur commented 1 year ago

also experiencing this issue, to slightly mitigate (but not solve):

* set displacement in pixels to 1

* don't set the width to 100%

However, doing this causes the guake window to 'crawl' down after toggling guake visibility.

This solution does not work for me.

JackieCui00 commented 1 year ago

same problem here.

I'm using archlinux, and downgrading guake from guake-3.10-1-any.pkg.tar.zst => guake-3.9.0-3-any.pkg.tar.zst solves this problem.

So, it must be that something added recently causes this.

manfrid commented 1 year ago

I'm freaking out, same problem.

$ guake --support Guake Version: 3.11.dev0 Vte Version: 0.72.1 Vte Runtime Version: 0.72.1 -------------------------------------------------- GTK+ Version: 3.24.37 GDK Backend: I downgrade guake to 3.9.0 lauch guake failed. Traceback (most recent call last): File "/usr/lib/python3.11/importlib/metadata/__init__.py", line 563, in from_name return next(cls.discover(name=name)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ StopIteration During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/usr/bin/guake", line 33, in sys.exit(load_entry_point('guake==3.9.1.dev0', 'console_scripts', 'guake')()) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/bin/guake", line 22, in importlib_load_entry_point for entry_point in distribution(dist_name).entry_points ^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/importlib/metadata/__init__.py", line 981, in distribution return Distribution.from_name(distribution_name) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/importlib/metadata/__init__.py", line 565, in from_name raise PackageNotFoundError(name) importlib.metadata.PackageNotFoundError: No package metadata was found for guake
madhur commented 1 year ago

I have switched to Kitty due to this bug

Davidy22 commented 11 months ago

To the ones observing a regression, the only commit that seems to be related that was made in the time frame is, deffa2b2f9f59570faba32d2b1af715b7d41f331, I've made a branch at https://github.com/Davidy22/guake/tree/revert with that commit reverted, if it's reported that this resolves the regression then I'll merge the revert.

keithgg commented 3 months ago

To the ones observing a regression, the only commit that seems to be related that was made in the time frame is, deffa2b, I've made a branch at https://github.com/Davidy22/guake/tree/revert with that commit reverted, if it's reported that this resolves the regression then I'll merge the revert.

@Davidy22 I can confirm this fixes it. The problem persists on master.

goodevilgenius commented 1 month ago

Having this issue as well. I'm finding a weird side effect is that if I go fullscreen, that works, but coming out of fullscreen, it stays the same fullscreen size, but the top-left corner goes back to where it was when it wasn't fullscreen, and centered on the screen, resulting in part of it flowing off screen.

Toggle it off and on fixes this, but still annoying.