Guake / guake

Drop-down terminal for GNOME
https://guake.github.io
GNU General Public License v2.0
4.37k stars 577 forks source link

Guake always starts in fullscreen once fs is used #2178

Open mutech opened 1 year ago

mutech commented 1 year ago

Describe the bug

After fullscreen has been used, guake will always appear in fullscreen mode from then on.

Expected behavior

Guake should either appear in the same configuration when it was hidden or always start in normal or fullscreen mode according to the setting of the main window.

Actual behavior

Guake respects the "start fullscreen setting" = "off" until fullscreen has been used and from then on ignores it on activation for as long as guake runs.

To Reproduce

$ guake --support Guake Version: 3.8.5 Vte Version: 0.68.0 Vte Runtime Version: 0.68.0 -------------------------------------------------- GTK+ Version: 3.24.33 GDK Backend:
mutech commented 1 year ago

There is a bit more to this: I'm using a custom gnome keyboard shortcut for fullscreen (not F11) while guake itself is configured to use F11 as shortcut.

If I change the guake window back from fullscreen using the guake shortcut, it works as expected, while using the gnome-shortcut also changes from fullscreen to normal, but as the described effect.

When I'm using the same keyboard shortcut in gnome and guake, the bug is there (guake probably never sees the keyboard shortcut).

So this bug appears only if the windowmanager/desktop sends a fullscreen request and not if guake processes its own keyboard shortcut.

Apparently, the window geometry used for restoring the window after a hide is not recorded correctly when a WM leave fullscreen request comes in.