search

Guake / guake

Drop-down terminal for GNOME
https://guake.github.io
GNU General Public License v2.0
4.37k stars 577 forks source link

Enable the use of AyatanaAppIndicator #2200

Closed EbonJaeger closed 8 months ago

EbonJaeger commented 9 months ago

This uses the newer successor to AppIndicator3 for the tray icon implementation, with a fallback to the older AppIndicator3 if the Ayatana version is not found. AyatanaAppIndicator is backwards compatible with AppIndicator3, so the API remains the same. The icon is also fixed.

Tested on Solus 4.4 with Budgie Desktop 10.8.

Ref https://github.com/BuddiesOfBudgie/budgie-desktop/issues/446 Fixes #433

Davidy22 commented 8 months ago

Sorry about the delay, been a little buried. Couldn't reproduce, can't confirm for myself but if this works for you then it should be fine. CI is complaining about black, a passthrough of that should silence that and this'll be good to go.

EbonJaeger commented 8 months ago

No problem, I know the feeling, heh.

Davidy22 commented 8 months ago

Linter's now objecting to the inline import. The pylint exclusion comments might need to be on the first line where the import keyword is, I think there should be a way for you to turn CI on with your fork so that you can get feedback from our checks faster. Locally, make check should also do it.

EbonJaeger commented 8 months ago

Hopefully this does it. Thanks for pointing out make check, I had overlooked it. Had to edit the .flake8 file to get it to actually work; newer versions of Flake appear to no longer allow inline comments in lists.