Guake / guake

Drop-down terminal for GNOME
https://guake.github.io
GNU General Public License v2.0
4.37k stars 577 forks source link

Pipfile: Python requirements are the wrong way around #2202

Open Staudey opened 9 months ago

Staudey commented 9 months ago

Unless I'm completely mistaken the Python version requirements for scandir and typing are the wrong way around in the Pipfile. Both modules/functions are part of Python >= 3.5, but the Pipfile requires them for Python > 3.5 (i.e. all versions that already include that functionality, except 3.5 itself), instead of Python < 3.5 (i.e. all versions that need this functionality in form of an extra module)

https://github.com/Guake/guake/blob/dcbf64c24e133b57d9023347bd17c13589ebb85f/Pipfile#L30 https://github.com/Guake/guake/blob/dcbf64c24e133b57d9023347bd17c13589ebb85f/Pipfile#L42

Both should be "python_version < '3.5'"

This even was the case before this commit: https://github.com/Guake/guake/commit/a38b47c97ca1161f82be9269fd7b4a418a6458da#diff-230078d672f10d17463a8a6265cad825b790885898256a3365be90685caac58d