search

Guake / guake

Drop-down terminal for GNOME
https://guake.github.io
GNU General Public License v2.0
4.37k stars 577 forks source link

Different content of the tarball downloaded from pypi and github #2204

Open Requion opened 9 months ago

Requion commented 9 months ago

Describe the bug

The content of the tarball differs depending on if downloaded from pypi vs github.

Expected behavior

Content of the tarballs should probably be the same

Actual behavior

From what i saw, the tarball from pypi is missing the guake/tests directory and contains a guake/_version.py. It is the other way around with the tarball from github.

To Reproduce

Download and extract the tarballs. Checked with multiple versions (3.7.0, 3.8.5, 3.10) but don't think this is related.

This is not related to running / installing Guake so i don't think the support output is necessary. This is rather related to packaging Guake for Void Linux. Currently, Void is building Guake from source (see template) which uses the tarball from pypi.org as described in Guakes docs. But it also tries to run tests (related line), which fails because the tests are missing in the used tarball.

My question now would be if the tests missing from the pypi tarball is intended or if they can be included there? Alternatively i would be happy to get more insight on how packaging is supposed to be done correctly. I did check the Help for Package maintainers page of the docs, which does not mention the tests.

Regards Requion

novaTopFlex commented 2 months ago

The README states that the GitHub tarball packages are missing an essential component of the build system that is present on the PyPI.