Guake / guake

Drop-down terminal for GNOME
https://guake.github.io
GNU General Public License v2.0
4.45k stars 579 forks source link

Input lag when '━' character is visible #2229

Closed adombeck closed 8 months ago

adombeck commented 8 months ago

I'm experiencing a weird issue where Guake is becoming incredibly slow at processing my keyboard inputs after I used git diff or git show with https://github.com/dandavison/delta as the pager.

I tracked the issue down to the '━' character which is printed as separators by delta.

I can reliably reproduce the issue by running this a few times in Guake:

echo ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

The more often I run it, the slower Guake becomes.

When I clear the terminal with clear, there is no input lag anymore.

GNOME Terminal is not affected, so I assume it's a Guake issue.

It seems to be unrelated to the shell, at least I can reproduce it both with zsh as bash.

$ guake --support Guake Version: 3.10 Vte Version: 0.75.92 Vte Runtime Version: 0.75.92 -------------------------------------------------- GTK+ Version: 3.24.41 GDK Backend:
egmontkob commented 8 months ago

Thanks for the report! VTE co-developer here. I can reproduce the issue with gnome-terminal, too.

I've forwarded the report upstream: https://gitlab.gnome.org/GNOME/vte/-/issues/2757 https://gitlab.gnome.org/GNOME/vte/-/issues/2758

adombeck commented 8 months ago

I can reproduce the issue with gnome-terminal, too.

I've forwarded the report upstream

Thanks! I wasn't able to reproduce the issue in GNOME Terminal in my initial tests, where I printed the '━' character about 500 times which already slowed down Guake a lot but did not have any noticeable effect in GNOME Terminal. Only after printing the character about 20000 times now I begin to see some slow down in GNOME Terminal as well, so maybe you're right and the bug is actually in VTE and Guake is just more strongly affected by the bug than GNOME Terminal for some reason.

egmontkob commented 8 months ago

Out of curiosity: do you have gnome-terminal 3.51-ish (gtk3) or 3.97 (gtk4)?

adombeck commented 8 months ago
$ gnome-terminal --version
# GNOME Terminal 3.51.90 using VTE 0.75.92 +BIDI +GNUTLS +ICU +SYSTEMD
egmontkob commented 8 months ago

Fixed for the forthcoming stable vte 0.76 release.

adombeck commented 8 months ago

Awesome! I just briefly scrolled through the two upstream issues you created and can tell you put a lot of effort into this, so thanks a lot for all you work, it's really appreciated! :)