GuanpengR / pe

0 stars 0 forks source link

Changes in JSON not reflected #8

Open GuanpengR opened 1 week ago

GuanpengR commented 1 week ago

image.png

image.png

In the addressbook.json, I have marked the attendance of Alice for tutorial 12 as absent, however even with running list command on the app does not update the correct attendance for tutorial 12.

soc-pe-bot commented 4 days ago

Team's Response

You have edited the JSON file correctly. However, to see the changes in ConTActs, you have to close the app and reopen it (also make sure to save the data file changes). The commands do not use the data file directly, but the internal model within the app to make changes, then OVERWRITES the current data file.

Preferably, you should only be editing the JSON data file while the app is closed, this is because editing the file whilst running the app could lead to undesirable or undefined behaviours should you accidentally save corrupted data (loss of all data/crashes) because all exception handling done by the app will be bypassed.

Would like to reject because JSON is editable, just not while the app is running, as all exception handling is bypassed.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The user guide states that you are welcomed to update data directly by editing the data file but does not state anything about the state of the app. Hence it can be interpreted either ways and should not be rejected totally as it is indeed a present issue.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]