search

GuardKenzie / miniplayer

A curses based mpd client with basic functionality and album art.
MIT License
120 stars 8 forks source link

Add mpd readpicture method as an option in miniplayer #29

Closed aaw3 closed 1 year ago

aaw3 commented 1 year ago

I wasn't able to get miniplayer working for the the longest time and realized that it's because of the way I have the cover art setup. I embed the cover art into all of my audio files rather than putting the cover.png in the album's directory.

This pull request fixes said issue by adding a config option to use mpd's "readpicture" function which extracts the cover art from the audio file.

aaw3 commented 1 year ago

I made it a separate config variable because I assume a person would only have it as either albumart or readpicture and it would be unnecessary to always call albumart when updating the album art image if they only use readpicture because of embedded art. But, you're right in that simply checking for both if the first fails would be a lot simpler and also would probably be better in weird cases where you have some albums setup with a cover.png and others with with the album art directly embedded. I will be pushing the update shortly.

aaw3 commented 1 year ago

Update pushed.

GuardKenzie commented 1 year ago

Sorry for the late response. Looks good!