search

GuardianLabs / guardian-keyper

Flutter app for backing up secrets by splitting those among friends
Other
6 stars 5 forks source link

Amplitude event for Finish AddSecret triggers only on error #13

Closed ichorid closed 2 years ago

ichorid commented 2 years ago

Apparently, Finish AddSecret event is only logged on flow an error (_showRejected): https://github.com/GuardianLabs/guardian-keyper/blob/0220e1c8f77adbf15657a39e915a39ffd6eef912/lib/src/recovery_group/add_secret/pages/secret_transmitting_page.dart#L141

Instead, it should be triggered on _showSuccess: https://github.com/GuardianLabs/guardian-keyper/blob/0220e1c8f77adbf15657a39e915a39ffd6eef912/lib/src/recovery_group/add_secret/pages/secret_transmitting_page.dart#L92