Guarmanda / LootChest

Plugin to reload chest with hologram, particles, and editing menu
GNU General Public License v3.0
9 stars 21 forks source link

Updating the data.yml and doing /lc reload wipes changes #53

Closed TomLewis closed 6 months ago

TomLewis commented 11 months ago

We need the ability to manage the data not in-game using an editor, to move data between servers live, without a reboot. Theres an issue where if you edit the data.yml and do a /lc reload, it just wipes it back to what it was before.

Can these be fixed as a priority please.

Guarmanda commented 11 months ago

If you want to edit the data file, the plugin (or the server) has to be stopped. Let's explain:

TomLewis commented 11 months ago

Oh yeah I gathered, the reload command should re-pull the data.

Let me give you is few reasons.

It's common practice across most plugins to allow this sort of behaviour from an moderation and admin perspective, hopefully we can get the same updated with this!

Guarmanda commented 11 months ago

This will probably lead to a new line in the config "SaveDataFileDuringReload"

TomLewis commented 11 months ago

Yeah thats good for me! Would be superb to have this.

TomLewis commented 10 months ago

@Guarmanda bit of a issue, can't even reboot and put over new data, it must overwrite it when the server shuts down on a reboot 😕

Guarmanda commented 6 months ago

yes it does: the data file is saved on shutdown, so you can only replace it when server is completelly off I'll add that config line anyway

Guarmanda commented 6 months ago

Done

TomLewis commented 6 months ago

Nice 👍