search

Guarmanda / LootChest

Plugin to reload chest with hologram, particles, and editing menu
GNU General Public License v3.0
9 stars 21 forks source link

Hologram on 1.20.4 shows too low, making it dark #59

Closed mrfloris closed 1 month ago

mrfloris commented 3 months ago

The light level of holograms is wrong due to the hologram being a bit too low. This doesn't always seem to happen on all the chests, but it happens, and in 1.20.4, it happens a lot more.

Screenshot 2024-04-10 at 09 09 21 Screenshot 2024-04-10 at 09 07 44

We are using CMI with CMI hologram (9.7.0.x) if that makes a difference. data.yml.zip

No startup, shutdown or usage errors in latest.log, if you have any questions, feel free to let me know. You can check how it looks at 1moreblock.com at /warp charlie, once they are loaded (mrfloris, I can help with that)

Guarmanda commented 3 months ago

This config line could solve your problem: Hologram_distance_to_chest: 1

I'll may add 0.2 to that number for future versions

Guarmanda commented 3 months ago

I'll also add that lootchest doesn't connect to any plugin to make holograms, it uses an api compatible from 1.8 to 1.20, because I don't want it to depend on anything. Using a server's hologram plugin would makes too much different behaviors, like if you use a plugin or another, how you configured your hologram plugin, if the plugin really works or not with your server version... It would be too much complicated for me to debug/maintain

mrfloris commented 3 months ago

This config line could solve your problem: Hologram_distance_to_chest: 1

I'll may add 0.2 to that number for future versions

Och, that's an oversight on my part that I could have played with. Thank you for the help. I will try some stuff out.

I'll also add that lootchest doesn't connect to any plugin to make holograms, it uses an api compatible from 1.8 to 1.20, because I don't want it to depend on anything. Using a server's hologram plugin would makes too much different behaviors, like if you use a plugin or another, how you configured your hologram plugin, if the plugin really works or not with your server version... It would be too much complicated for me to debug/maintain

100% fine by me! Makes updating to 1.20.5 a lot smoother.

mrfloris commented 3 months ago

This config line could solve your problem: Hologram_distance_to_chest: 1

I'll may add 0.2 to that number for future versions

I had time to play around 1.2 is a fine setting.

Guarmanda commented 3 months ago

100% fine by me! Makes updating to 1.20.5 a lot smoother.

My plugin still depends on protocollib because of this API, and it seems like it doesn't work in 1.20.5 sadly^^

mrfloris commented 3 months ago

100% fine by me! Makes updating to 1.20.5 a lot smoother.

My plugin still depends on protocollib because of this API, and it seems like it doesn't work in 1.20.5 sadly^^

There's a WIP release of PL for 1.20.5/6 https://ci.dmulloy2.net/job/ProtocolLib/changes

Guarmanda commented 1 month ago

My plugin will use a new library for holograms and won't have protocollib requirements anymore

Guarmanda commented 1 month ago

The push was made for the library already, holograms are slightly higher, I'll close this issue