search

Guarmanda / LootChest

Plugin to reload chest with hologram, particles, and editing menu
GNU General Public License v3.0
11 stars 23 forks source link

Armor stands not being cleared up when chest dropped #66

Open TomLewis opened 4 months ago

TomLewis commented 4 months ago

Were on the hunt for bad entitiy farms and one of the issues that appered in our search turned out to be LootChest not cleaning up the armor stand mess its made!

here are 693 armor stands all in the same spot. I have had to run /minecraft:kill @e[type=armor_stand,distance=..10] to kill them.

please can you make sure you are removing any entities you are throwing into the world that should be temporary!

unnamed

unnamed

Guarmanda commented 4 months ago

Lootchest generates armorstands only for fall effect 🤔 maybe I should replace the fall effect block with packets to not generate entities at all

TomLewis commented 4 months ago

sounds like a good idea!

Guarmanda commented 4 months ago

Oh, you can also not use armorstands for fall effect, but you'll be limited to some blocks

Guarmanda commented 1 month ago

I learnt how to use NMS and created armorstands packets instead of real armorstands. This issue should be gone for next release; this was the last entity spawned by my plugin (fall effect also spawns fireworks, but they aren't problematic). Packets haves the drawnback to need to be moved manually, I don't know if it'll consume cpu or not, but at least, no more bugged entities. This feature will work in 1.17+ only, armorstand will be totally removed and falling block will be forced from older versions

TomLewis commented 1 month ago

awesome!