[Bug]: On smaller screens the anchor (#) on headings partly falls of the screen

GuavaCZ / filament-knowledge-base

MIT License

144 stars 21 forks source link

[Bug]: On smaller screens the anchor (#) on headings partly falls of the screen #18

Closed gavinhewitt closed 6 months ago

gavinhewitt commented 6 months ago

What happened?

See title

How to reproduce the bug

Package Version

latest

PHP Version

latest

Laravel Version

latest

Which operating systems does with happen with?

No response

Notes

No response

lukas-frey commented 6 months ago

Oops, good catch. I'll try to work through all the issues tomorrow :-)

gavinhewitt commented 6 months ago

Oops, good catch. I'll try to work through all the issues tomorrow :-)

Personally not a fan of those markers. I think they should be, again, optional :-D

lukas-frey commented 6 months ago

Oops, good catch. I'll try to work through all the issues tomorrow :-)

Personally not a fan of those markers. I think they should be, again, optional :-D

Why optional though? Just don't use them if you don't like them and they will never appear anywhere? :D

EDIT: Or actually, what are you referring to? Table of contents on the right or the actual markers in markdown? (when you write ==something==)

gavinhewitt commented 6 months ago

Sorry my bad, I meant the anchors that are automatically added to headings :-) (#)

(don't know why I called them markers :D)

lukas-frey commented 6 months ago

Oooh, you mean that! So you're suggesting to keep the table of contents on the right, but disable the anchors on the left? 🤔

Would you prefer if it appeared only on hover though? That was also a possibility I was considering :D

gavinhewitt commented 6 months ago

Oooh, you mean that! So you're suggesting to keep the table of contents on the right, but disable the anchors on the left? 🤔

Yes

Would you prefer if it appeared only on hover though? That was also a possibility I was considering :D

That would be one possibility yes. But I wouldn't miss them if they were gone completely :-)

lukas-frey commented 6 months ago

Yeah, I'm thinking adding some "empty" gu-kb- classes everywhere just like filament does, so you can style most stuff however you see fit, add a disable option and maybe one or two presets you can choose from (the way it is now + maybe the hovering version).

lukas-frey commented 6 months ago

Fixed in 1.3.0. Works on smaller screens and can be disabled entirely.

gavinhewitt commented 6 months ago

Thanks Lukas, you rock!