Gubaer / josm-contourmerge-plugin

Merges contours of adjacent areas in JOSM
GNU General Public License v3.0
5 stars 3 forks source link

Anomalies when merging boundaries around complex geometries #17

Closed Gubaer closed 6 years ago

Gubaer commented 6 years ago

from Andrew, By email :

One is that merging boundaries around complex geometries, where each way is drawn in a different direction, results in self-intersecting ways, crossing ways, overlapping ways and other similar issues.

Gubaer commented 6 years ago

One is that merging boundaries around complex geometries, where each way is drawn in a different direction, results in self-intersecting ways, crossing ways, overlapping ways and other similar issues.

To you have small sample OSM files with OSM data set where the problem occurs?

Gubaer commented 6 years ago
Gubaer commented 6 years ago

I can't reproduce this. The data in the bounding box https://www.openstreetmap.org/#map=17/-43.27241/145.86393 don't match anymore with your screen recording.

Do you have another sample where the problem occurs ?

Gubaer commented 6 years ago

From Andrew via mail:

I was able to replicate the error in this area the first time I tried it, but not the second time. It seems to be some kind of intermittent issue:

https://www.openstreetmap.org/#map=15/23.63038/68.51157

Thanks!

Gubaer commented 6 years ago

I think, I see what the problem is:

Currently, the plugin merges exactly one way (the drag source) to exactly another way (the drag target).

If more than one ways share exactly the same nodes between the two yellow crosses on the drag source, then the plugin only merges one. The other ways stay where they are.

As a manual workaround, • again set the two yellow crosses on the way which was not aligned • then drag it again on the target

I'll see whether I can implement an enhancement which merges not only one, but all the ways from the drag source onto the drag target.

Gubaer commented 6 years ago

Should be fixed in relase v0.1.3. Please update the plugin in JOSMs preferences dialog.