search

Gubaer / josm-scripting-plugin

Task automation in the OpenStreetMap editor JOSM
https://gubaer.github.io/josm-scripting-plugin
GNU General Public License v3.0
26 stars 9 forks source link

Script runs only once if launched from toolbar button #107

Closed n-timofeev closed 10 months ago

n-timofeev commented 1 year ago

JOSM 18822, plugin v0.3.0, OpenJDK 21 + GraalJS 23.0.0, Windows 11

import josm from 'josm'
josm.alert('ok')

If I run this script from console, it works, but if I run it from toolbar button, a window appears popup and script is executed, but only once. The next time the window appears, but script is not running.

DavidPx commented 12 months ago

I can confirm this. It would also be very nice if the engine dialog would not appear with every toolbar button click!

Gubaer commented 11 months ago

Thanks for reporting! I'll have time to look into this in December.

Gubaer commented 10 months ago

Today, I've published the release v0.3.1.

Unfortunately, I had to remove support for toolbar icons, which launch a custom script. However, if you click on an entry for a most recently run script in the Scripting menu, you no longer have to select a scripting engine. The menu entry remembers the scripting engine chosen for the first invocation.

I plan to implement a custom toggle dialog for a list of personal and custom scripts. It will be available in JOSM's right-hand sidebar. I plan to include it in the next release, around March 2024.

Filip10 commented 7 months ago

@Gubaer I think, that this change has also disabled keyboard shortcuts for scripts saved on toolbar. Am I right?

Gubaer commented 7 months ago

@Gubaer I think, that this change has also disabled keyboard shortcuts for scripts saved on toolbar. Am I right?

Yes, unfortunately, the JOSM and plugin code bases diverged too much. I had to remove a clumsy piece of code from the plugin.

I still plan to provide an alternative. However, currently, I'm behind the announced schedule.