raimund-schluessler commented 2 years ago

This PR implements opening bmlab files in Impose.

Requires https://github.com/BrillouinMicroscopy/bmlab/pull/70, https://github.com/BrillouinMicroscopy/bmlab/pull/72 and a new release to pypi.

raimund-schluessler commented 2 years ago

This should be good to go as soon as https://github.com/BrillouinMicroscopy/bmlab/pull/70 is merged and released to PyPi.

paulmueller commented 2 years ago

I would like to wait for the next release of bmlab (ideally 0.1.0 (https://github.com/BrillouinMicroscopy/bmlab/issues/73)) so that the tests pass.

codecov-commenter commented 2 years ago

Codecov Report

Merging #22 (666949f) into main (b47cd47) will increase coverage by 0.18%. The diff coverage is 95.12%.

:exclamation: Current head 666949f differs from pull request most recent head 0049d63. Consider uploading reports for the commit 0049d63 to get more accurate results

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   77.13%   77.32%   +0.18%     
==========================================
  Files          35       35              
  Lines        2384     2412      +28     
==========================================
+ Hits         1839     1865      +26     
- Misses        545      547       +2

Impacted Files	Coverage Δ
impose/formats/fmt_h5.py	`95.74% <95.12%> (-4.26%)`	:arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

GuckLab / impose

Allow to open bmlab files #22

Codecov Report