GuckLab / impose

Align microscopy images using custom-defined structural patterns and superimpose those on data from other imaging modalities.
GNU General Public License v3.0
1 stars 0 forks source link

Add Github actions for DMG and EXE packages #31

Closed raimund-schluessler closed 2 years ago

raimund-schluessler commented 2 years ago

This enhances the Github check action to build installer packages for MacOSX and Win. The packages are uploaded as artifacts to Github and can be downloaded from the Github Actions page.

Closes #29.

What is still missing is an Action to create packages and a release when a new tag is pushed. But I would propose to add this in a follow-up PR, since this one is already huge.

raimund-schluessler commented 2 years ago

For whatever reason actions don't run at all at the moment. πŸ˜•

Edit: Github status page states delays in actions atm. Perfect time to debug some actions πŸ™ˆ

codecov-commenter commented 2 years ago

Codecov Report

Merging #31 (7a65ca2) into main (f1b61bc) will decrease coverage by 0.40%. The diff coverage is 0.00%.

:exclamation: Current head 7a65ca2 differs from pull request most recent head 9192371. Consider uploading reports for the commit 9192371 to get more accurate results

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   77.69%   77.28%   -0.41%     
==========================================
  Files          35       35              
  Lines        2457     2470      +13     
==========================================
  Hits         1909     1909              
- Misses        548      561      +13     
Impacted Files Coverage Ξ”
impose/__main__.py 0.00% <0.00%> (ΓΈ)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

paulmueller commented 2 years ago

I think the build pipeline should be fine like this. There have been a few updates (pyinstaller, scipy).

raimund-schluessler commented 2 years ago

The windows installer works fine. The Mac DMG says "β€œImpose.app” is damaged and can’t be opened. You should move it to the Bin."

raimund-schluessler commented 2 years ago

The windows installer works fine.

I have to correct myself. Installing Impose uninstalls BMicro and vice-versa.

raimund-schluessler commented 2 years ago

The windows installer works fine.

I have to correct myself. Installing Impose uninstalls BMicro and vice-versa.

Windows installer works fine now. Lives happily together with BMicro. πŸ‘

raimund-schluessler commented 2 years ago

But getting the tag in the _version.py script does not work. Not sure if only related to this PR or not. The installer script generates a file named Impose_2022.05.05.post08_win_64bit_setup.exe whereas it should read Impose_0.2.2.post08_win_64bit_setup.exe (not the current date, but the tag/version 0.2.2).

paulmueller commented 2 years ago

Is there an option for GHA to also pull/fetch the tags? The tags are important.

raimund-schluessler commented 2 years ago

Is there an option for GHA to also pull/fetch the tags? The tags are important.

I think that's not the issue. It also fails locally now for me.

Debugging _version.py shows that the call to git does not return something meaningful, but gives

b"fatal: unsafe repository ('D:/Data/Biotec/Software/00_Programs/BMicro' is owned by someone else)\nTo add an exception for this directory, call:\n\n\tgit config --global --add safe.directory D:/Data/Biotec/Software/00_Programs/BMicro\n"
raimund-schluessler commented 2 years ago

The Mac DMG says "β€œImpose.app” is damaged and can’t be opened. You should move it to the Bin."

In principle the DMG seems to be fine. But when you download it via browser, Mac somehow flags it as unsafe and acknowledges running the DMG with this obscure, if not downright wrong, error message.

Downloading it on a windows machine and then copying the DMG file via a USB stick works flawlessly. Obviously, USB sticks have never been used to transfer malware and can be considered safe without any problem πŸ™„

paulmueller commented 2 years ago

That is weird!