Closed LokiMidgard closed 3 years ago
I really like the change. Only 2 minor details:
In any case, I'm going to merge this pull request later. The only part that I will remove is the minor/major for now.
I'm not sure what you mean when you say
breaks the "inspect"
when I us the inspect function in the browser it shows :after
and :before
without problems.
Putting this in the background will make the HTML easier since no overlay for the cost is needed. But then you would 4 different images. With using the overlay for cost, it could actually go down to one.
Ok I think I get now what you mend.
I fixed the image size on the rule-text overlay.
I also removed the minor major border. But I hope there is a way to get the border back without a drawback.
E.g. instead of adding the border over every thing the boarder could be a normal element in the HTML and the content of the card is just in that HTML element. Just the background must be visible outside of that border... 🤔
But that would propably a different pull request.
I added a background texture to the cards:
I also replaced the background color of threshold and target with an textures.
Major and Minor cards now also have a coressponding border: