Yexo
commented
2 years ago Where did you find the nice quality images for the back and front of the card? I'd love to update the Adversary boards. The image is too low resolution for my taste.
Honestly I don't reminder. Deso provided high-quality images https://discord.com/channels/707232612355276913/707234642901860392/834162486164193330 and https://discord.com/channels/707232612355276913/707234642901860392/834162534473924608, I should replace mine with those.
Can you further explain the changes to board_front.js? I take it the intent is to separate the construction of innates on a board into its own function, that you then use to create aspects 'innates' in aspect.js, is that right?
Again, I haven't touched this code in over a year. But I'm pretty sure that yes, the intent was to move the construction of innates to a separate function (parseInnatePower) which I could then reuse.
If I'm right, should we move 'parseInnatePower()' to the general.js? It feels cleaner to have all the shared functions in the general file, but I don't have any experience with coding convention on large projects so I'm genuinely asking.
I'd prefer a new file "innate.js". Seperating out functionality is good, but "general.js" very easily becomes a mix of everything (even though it's currently still very small).
There's some conflicts with this in my own code. Nothing I wouldn't be able to solve but I'm not sure how that process goes.
Happy to help, but I'm not sure where to start. Perhaps a real-time discussion helps?
I was able to reuse a lot from the Spirit Board templates, so the amount of new code is fairly small. There is still room for more cleanup/consolidation and renaming of a few files now shared between Board and Aspect templates, but I wanted to show this first. Happy to continue which such a cleanup if you agree.