Gue3bara / Cairo

Cairo is a contemporary Arabic and Latin typeface family. Mohamed Gaber extended the famous Latin typeface family Titillum Web to support the Arabic script, with a design that is based on the Kufi calligraphic style.
SIL Open Font License 1.1
168 stars 22 forks source link

New Heavy weight from commit 4f917cb causing weight coordinates issues in QA #50

Closed eliheuer closed 4 years ago

eliheuer commented 4 years ago

The new Heavy weight from commit 4f917cb is causing some Fontbakery QA fails, see the report here and below.

Fontbakery report

Fontbakery version: 0.7.20

[4] Cairo[wght].ttf 🔥 FAIL: Variable font weight coordinates must be multiples of 100.

The named instances on the weight axis of a variable font must have coordinates that are multiples of 100 on the design space.

🔥 FAIL: Check variable font instances have correct coordinate values 🔥 FAIL: Check variable font instances have correct names


Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 4 3 36 9 114 0
0% 2% 2% 22% 5% 69% 0%

Note: The following loglevels were omitted in this report:

eliheuer commented 4 years ago

I'm experimenting with ways to fix this now, will report back with what I find. The main issue is that Black and Heavy are both set to 900 in the instance field.

heavy

Gue3bara commented 4 years ago

@eliheuer I noticed the issue as I was doing the comparison between the old and new Black i noticed that it's not being recognized and still compared to the "heavy" weight this seems like a Glyphs limitation, I wonder if it can be solved used a custom parameter i will try that out and report it on Glyphs form to ask for help

Gue3bara commented 4 years ago

@eliheuer i just added the custom parameter for the weight class i think this should work

eliheuer commented 4 years ago

Nice I was doing the same. Thanks. I think dave said he wanted the heavy to be 1000, but I've never worked on a font that goes beyond 900, so I'm not completely sure what the best way to do this is.

Edit: I see the new source, trying it now, thanks.

Gue3bara commented 4 years ago

@eliheuer I just pushed a new build there was an interpolation issue with the $ Oslash & oslasg that might have caused the issue, i think we should give the new build a try

eliheuer commented 4 years ago

Sorry for the lack of progress, the new builds are crashing the QA tools, I think it might be due to the new heavy weight. So it's a problem with the GF QA tools, not the new source files.

eliheuer commented 4 years ago

I talked with Marc today, and the QA tools need an update before they can handle a 1000 Heavy weight, I made an issue about this here here: https://github.com/googlefonts/gfregression/issues/61

eliheuer commented 4 years ago

Marc said this will be fixed tomorrow, closing it now, will reopen if something goes wrong with that.