Gue3bara / Lemonada

Lemonada is a modern Arabic and Latin typeface family designed by Mohamed Gaber (Arabic) and Eduardo Tunni (Latin)
SIL Open Font License 1.1
33 stars 9 forks source link

Minor things #6

Closed davelab6 closed 8 years ago

davelab6 commented 8 years ago

In Font Info, Font

screen shot 2016-03-02 at 01 53 22

Then add the AUTHORS and the other 2 files as per https://github.com/googlefonts/gf-docs/blob/master/ProjectChecklist.md

In Font Info, Masters

In Font Info, Instances

screen shot 2016-03-02 at 01 56 01
Gue3bara commented 8 years ago

DONE Thank you Dave so much for your time and help Thank you man :)

Gue3bara commented 8 years ago

why do we set italic angel to zero? this value was set by Eduardo btw and now if i apply this the whole kerning is messed up

davelab6 commented 8 years ago

It should not effect the kerning...

We do not set it because the fonts are presented to the system as upright/romans, not italics; for them to be italics, they need to have 'real' upright/romans which don't exist.

cc @etunni

davelab6 commented 8 years ago

For italic angle, you can set it to zero as an instance custom parameter:

screen shot 2016-03-02 at 16 48 15
Gue3bara commented 8 years ago

and keeping it 9 as it was in the masters, right?

davelab6 commented 8 years ago

No, it must be zero because these fonts are presented to the system as roman/upright styles.

Gue3bara commented 8 years ago

but this way i still have the same issue fixed masters angel to 0

screenshot 2016-03-03 00 02 46

added the custom parameter for all instanced set to 0

screenshot 2016-03-03 00 04 58

so i end up with the same result

screenshot 2016-03-03 00 05 41
davelab6 commented 8 years ago

oh I see. sorry, you can set the angle in the Metrics area back how it was, and leave the customParameter value at 0.0

Gue3bara commented 8 years ago

great now it's working perfect