Guekka / bethutil

Common utilities for working with bethesda assets (dds, nif, bsa, hkx...)
https://guekka.github.io/bethutil/
Mozilla Public License 2.0
4 stars 1 forks source link

Improve robustness #37

Closed Guekka closed 2 months ago

Guekka commented 2 months ago

More work on #7, some fixes

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 65.62500% with 33 lines in your changes missing coverage. Please review.

Project coverage is 75.31%. Comparing base (5d70b27) to head (dd5231a). Report is 58 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Guekka/bethutil/pull/37/graphs/tree.svg?width=650&height=150&src=pr&token=llth93S2Em&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+B)](https://app.codecov.io/gh/Guekka/bethutil/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+B) ```diff @@ Coverage Diff @@ ## main #37 +/- ## ========================================== - Coverage 76.97% 75.31% -1.67% ========================================== Files 33 37 +4 Lines 1781 1576 -205 ========================================== - Hits 1371 1187 -184 + Misses 410 389 -21 ``` | [Files](https://app.codecov.io/gh/Guekka/bethutil/pull/37?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+B) | Coverage Δ | | |---|---|---| | [include/btu/bsa/archive.hpp](https://app.codecov.io/gh/Guekka/bethutil/pull/37?src=pr&el=tree&filepath=include%2Fbtu%2Fbsa%2Farchive.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+B#diff-aW5jbHVkZS9idHUvYnNhL2FyY2hpdmUuaHBw) | `100.00% <ø> (ø)` | | | [include/btu/bsa/plugin.hpp](https://app.codecov.io/gh/Guekka/bethutil/pull/37?src=pr&el=tree&filepath=include%2Fbtu%2Fbsa%2Fplugin.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+B#diff-aW5jbHVkZS9idHUvYnNhL3BsdWdpbi5ocHA=) | `85.71% <ø> (+2.38%)` | :arrow_up: | | [src/bsa/pack.cpp](https://app.codecov.io/gh/Guekka/bethutil/pull/37?src=pr&el=tree&filepath=src%2Fbsa%2Fpack.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+B#diff-c3JjL2JzYS9wYWNrLmNwcA==) | `97.05% <100.00%> (+13.88%)` | :arrow_up: | | [src/modmanager/mod\_folder.cpp](https://app.codecov.io/gh/Guekka/bethutil/pull/37?src=pr&el=tree&filepath=src%2Fmodmanager%2Fmod_folder.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+B#diff-c3JjL21vZG1hbmFnZXIvbW9kX2ZvbGRlci5jcHA=) | `95.65% <100.00%> (-4.35%)` | :arrow_down: | | [src/bsa/plugin.cpp](https://app.codecov.io/gh/Guekka/bethutil/pull/37?src=pr&el=tree&filepath=src%2Fbsa%2Fplugin.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+B#diff-c3JjL2JzYS9wbHVnaW4uY3Bw) | `42.85% <0.00%> (-8.43%)` | :arrow_down: | | [src/hkx/anim.cpp](https://app.codecov.io/gh/Guekka/bethutil/pull/37?src=pr&el=tree&filepath=src%2Fhkx%2Fanim.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+B#diff-c3JjL2hreC9hbmltLmNwcA==) | `79.24% <87.50%> (-8.76%)` | :arrow_down: | | [src/bsa/archive.cpp](https://app.codecov.io/gh/Guekka/bethutil/pull/37?src=pr&el=tree&filepath=src%2Fbsa%2Farchive.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+B#diff-c3JjL2JzYS9hcmNoaXZlLmNwcA==) | `80.18% <46.66%> (+1.33%)` | :arrow_up: | | [include/btu/common/filesystem.hpp](https://app.codecov.io/gh/Guekka/bethutil/pull/37?src=pr&el=tree&filepath=include%2Fbtu%2Fcommon%2Ffilesystem.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+B#diff-aW5jbHVkZS9idHUvY29tbW9uL2ZpbGVzeXN0ZW0uaHBw) | `67.07% <65.67%> (-22.52%)` | :arrow_down: | ... and [18 files with indirect coverage changes](https://app.codecov.io/gh/Guekka/bethutil/pull/37/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+B) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/Guekka/bethutil/pull/37?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+B). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+B) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/Guekka/bethutil/pull/37?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+B). Last update [c27d90e...dd5231a](https://app.codecov.io/gh/Guekka/bethutil/pull/37?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+B). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar+B).