search

Guekka / bethutil

Common utilities for working with bethesda assets (dds, nif, bsa, hkx...)
https://guekka.github.io/bethutil/
Mozilla Public License 2.0
4 stars 1 forks source link

feat(bsa): improve archive name finding algorithm, simplify code #40

Closed Guekka closed 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.83%. Comparing base (8ca8743) to head (9c1f131).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Guekka/bethutil/pull/40/graphs/tree.svg?width=650&height=150&src=pr&token=llth93S2Em&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar)](https://app.codecov.io/gh/Guekka/bethutil/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar) ```diff @@ Coverage Diff @@ ## main #40 +/- ## ========================================== + Coverage 76.49% 77.83% +1.34% ========================================== Files 38 37 -1 Lines 1651 1620 -31 ========================================== - Hits 1263 1261 -2 + Misses 388 359 -29 ``` | [Files](https://app.codecov.io/gh/Guekka/bethutil/pull/40?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar) | Coverage Δ | | |---|---|---| | [include/btu/common/functional.hpp](https://app.codecov.io/gh/Guekka/bethutil/pull/40?src=pr&el=tree&filepath=include%2Fbtu%2Fcommon%2Ffunctional.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-aW5jbHVkZS9idHUvY29tbW9uL2Z1bmN0aW9uYWwuaHBw) | `100.00% <ø> (ø)` | | | [include/btu/common/string.hpp](https://app.codecov.io/gh/Guekka/bethutil/pull/40?src=pr&el=tree&filepath=include%2Fbtu%2Fcommon%2Fstring.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-aW5jbHVkZS9idHUvY29tbW9uL3N0cmluZy5ocHA=) | `94.23% <100.00%> (+1.54%)` | :arrow_up: | | [include/btu/bsa/settings.hpp](https://app.codecov.io/gh/Guekka/bethutil/pull/40?src=pr&el=tree&filepath=include%2Fbtu%2Fbsa%2Fsettings.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-aW5jbHVkZS9idHUvYnNhL3NldHRpbmdzLmhwcA==) | `61.94% <50.00%> (ø)` | | | [src/bsa/plugin.cpp](https://app.codecov.io/gh/Guekka/bethutil/pull/40?src=pr&el=tree&filepath=src%2Fbsa%2Fplugin.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-c3JjL2JzYS9wbHVnaW4uY3Bw) | `78.16% <85.48%> (+15.66%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/Guekka/bethutil/pull/40?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/Guekka/bethutil/pull/40?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar). Last update [8ca8743...9c1f131](https://app.codecov.io/gh/Guekka/bethutil/pull/40?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar).