Fixes, correctness and performance

[Guekka]

Basically way too much things in a single PR

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 85.41667% with 21 lines in your changes missing coverage. Please review.

Project coverage is 78.12%. Comparing base (1c46ac8) to head (ecc59b4).

Additional details and impacted files

[](https://app.codecov.io/gh/Guekka/bethutil/pull/42?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar) ```diff @@ Coverage Diff @@ ## main #42 +/- ## ========================================== + Coverage 77.83% 78.12% +0.28% ========================================== Files 37 38 +1 Lines 1620 1650 +30 ========================================== + Hits 1261 1289 +28 - Misses 359 361 +2 ``` | [Files](https://app.codecov.io/gh/Guekka/bethutil/pull/42?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar) | Coverage Δ | | |---|---|---| | [include/btu/common/functional.hpp](https://app.codecov.io/gh/Guekka/bethutil/pull/42?src=pr&el=tree&filepath=include%2Fbtu%2Fcommon%2Ffunctional.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-aW5jbHVkZS9idHUvY29tbW9uL2Z1bmN0aW9uYWwuaHBw) | `100.00% <ø> (ø)` | | | [include/btu/common/threading.hpp](https://app.codecov.io/gh/Guekka/bethutil/pull/42?src=pr&el=tree&filepath=include%2Fbtu%2Fcommon%2Fthreading.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-aW5jbHVkZS9idHUvY29tbW9uL3RocmVhZGluZy5ocHA=) | `100.00% <100.00%> (ø)` | | | [include/btu/modmanager/mod\_folder.hpp](https://app.codecov.io/gh/Guekka/bethutil/pull/42?src=pr&el=tree&filepath=include%2Fbtu%2Fmodmanager%2Fmod_folder.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-aW5jbHVkZS9idHUvbW9kbWFuYWdlci9tb2RfZm9sZGVyLmhwcA==) | `0.00% <ø> (ø)` | | | [include/btu/tex/functions.hpp](https://app.codecov.io/gh/Guekka/bethutil/pull/42?src=pr&el=tree&filepath=include%2Fbtu%2Ftex%2Ffunctions.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-aW5jbHVkZS9idHUvdGV4L2Z1bmN0aW9ucy5ocHA=) | `100.00% <ø> (ø)` | | | [src/bsa/archive.cpp](https://app.codecov.io/gh/Guekka/bethutil/pull/42?src=pr&el=tree&filepath=src%2Fbsa%2Farchive.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-c3JjL2JzYS9hcmNoaXZlLmNwcA==) | `75.43% <ø> (-0.44%)` | :arrow_down: | | [src/bsa/pack.cpp](https://app.codecov.io/gh/Guekka/bethutil/pull/42?src=pr&el=tree&filepath=src%2Fbsa%2Fpack.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-c3JjL2JzYS9wYWNrLmNwcA==) | `92.68% <ø> (ø)` | | | [src/bsa/unpack.cpp](https://app.codecov.io/gh/Guekka/bethutil/pull/42?src=pr&el=tree&filepath=src%2Fbsa%2Funpack.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-c3JjL2JzYS91bnBhY2suY3Bw) | `85.71% <ø> (ø)` | | | [src/tex/formats.cpp](https://app.codecov.io/gh/Guekka/bethutil/pull/42?src=pr&el=tree&filepath=src%2Ftex%2Fformats.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-c3JjL3RleC9mb3JtYXRzLmNwcA==) | `100.00% <100.00%> (+5.00%)` | :arrow_up: | | [src/tex/functions.cpp](https://app.codecov.io/gh/Guekka/bethutil/pull/42?src=pr&el=tree&filepath=src%2Ftex%2Ffunctions.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-c3JjL3RleC9mdW5jdGlvbnMuY3Bw) | `89.38% <ø> (+0.88%)` | :arrow_up: | | [src/tex/optimize.cpp](https://app.codecov.io/gh/Guekka/bethutil/pull/42?src=pr&el=tree&filepath=src%2Ftex%2Foptimize.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-c3JjL3RleC9vcHRpbWl6ZS5jcHA=) | `70.43% <92.30%> (+0.71%)` | :arrow_up: | | ... and [3 more](https://app.codecov.io/gh/Guekka/bethutil/pull/42?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/Guekka/bethutil/pull/42/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/Guekka/bethutil/pull/42?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/Guekka/bethutil/pull/42?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar). Last update [1c46ac8...ecc59b4](https://app.codecov.io/gh/Guekka/bethutil/pull/42?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar).